Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629710 - app-text/texlive-core-2017-r2 blocks update to app-text/poppler-0.61.1 (was: fails to build with app-text/poppler-0.58.0)
Summary: app-text/texlive-core-2017-r2 blocks update to app-text/poppler-0.61.1 (was: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
: 642554 (view as bug list)
Depends on:
Blocks: poppler-0.58.0
  Show dependency tree
 
Reported: 2017-09-02 23:56 UTC by Toralf Förster
Modified: 2018-01-09 22:22 UTC (History)
17 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.96 KB, text/plain)
2017-09-02 23:56 UTC, Toralf Förster
Details
app-text:texlive-core-2017-r2:20170902-222836.log.bz2 (app-text:texlive-core-2017-r2:20170902-222836.log.bz2,45.93 KB, application/x-bzip)
2017-09-02 23:56 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,108.23 KB, text/plain)
2017-09-02 23:56 UTC, Toralf Förster
Details
environment (environment,110.99 KB, text/plain)
2017-09-02 23:56 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,42.66 KB, application/x-bzip)
2017-09-02 23:56 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,43.60 KB, application/x-bzip)
2017-09-02 23:56 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,75.09 KB, application/x-bzip)
2017-09-02 23:56 UTC, Toralf Förster
Details
texlive-poppler-0.59.patch (texlive-poppler-0.59.patch,41.39 KB, patch)
2017-10-29 18:51 UTC, maurerpe
Details | Diff
texlive-core-2017-r3.ebuild (texlive-core-2017-r100.ebuild,11.39 KB, text/plain)
2017-10-29 18:52 UTC, maurerpe
Details
updated ArchLinux patch (texlive-poppler-0.59.patch,41.39 KB, patch)
2017-12-11 15:52 UTC, Rafał Mużyło
Details | Diff
"updated ArchLinux patch", backported for TL 2016 (texlive-core-2016-poppler060.patch,41.55 KB, patch)
2017-12-29 00:12 UTC, Andreas K. Hüttel
Details | Diff
Build log with -r3 error on poppler 0.57.0-r1 (app-text:texlive-core-2017-r3:20180107-195732.log.bz2,19.92 KB, application/x-bzip)
2018-01-07 20:46 UTC, Sebastian Pipping
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-09-02 23:56:15 UTC
/var/tmp/portage/app-text/texlive-core-2017-r2/work/texlive-20170524-source/texk/web2c/pdftexdir/pdftoepdf.cc: In destructor 'PdfObject::~PdfObject()':
/var/tmp/portage/app-text/texlive-core-2017-r2/work/texlive-20170524-source/texk/web2c/pdftexdir/pdftoepdf.cc:97:22: error: 'void Object::free()' is private within this context
         iObject.free();
                      ^
In file included from /var/tmp/portage/app-text/texlive-core-2017-r2/work/texlive-20170524-source/texk/web2c/pdftexdir/pdftoepdf.cc:49:0:

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-desktop_20170828-210912

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.4.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python2.7 (fallback)

java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.5.1 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

emerge -qpv app-text/texlive-core
[ebuild   R   ] app-text/texlive-core-2017-r2  USE="X luajittex source -cjk -doc -tk -xetex"
Comment 1 Toralf Förster gentoo-dev 2017-09-02 23:56:18 UTC
Created attachment 491966 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-09-02 23:56:22 UTC
Created attachment 491968 [details]
app-text:texlive-core-2017-r2:20170902-222836.log.bz2
Comment 3 Toralf Förster gentoo-dev 2017-09-02 23:56:25 UTC
Created attachment 491970 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2017-09-02 23:56:29 UTC
Created attachment 491972 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2017-09-02 23:56:32 UTC
Created attachment 491974 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2017-09-02 23:56:35 UTC
Created attachment 491976 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2017-09-02 23:56:38 UTC
Created attachment 491978 [details]
temp.tbz2
Comment 8 Marien Zwart 2017-09-03 03:07:42 UTC
I'm getting very similar errors building texlive-core after upgrading to app-text/poppler-0.58.0. Downgrading to the previous version (poppler-0.57.0) makes texlive-core build again.

Probably caused by https://cgit.freedesktop.org/poppler/poppler/commit/?id=9773c1534668d84b8267c3e5c9d612076fa231a5 which changed Poppler's API (there's a typo in the commit message, it says "made free() public" but it actually made it private).
Comment 9 Alexis Ballier gentoo-dev 2017-09-03 09:08:41 UTC
commit fe72f5e4dd250d053f0c524d2e26318bab22498f (HEAD -> master, origin/master, origin/HEAD)
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Sun Sep 3 11:07:38 2017 +0200

    app-text/texlive-core: Force poppler less than 0.58, bug #629710
    



Lars, I think this poppler version should be masked. Fix for texlive is definitely non trivial.
Comment 10 Marien Zwart 2017-09-03 09:15:11 UTC
I suspect bug 629708 is the same change non-trivially breaking cups-filters, FWIW (it's not just texlive-core that's broken).
Comment 11 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-09-03 22:17:27 UTC
(In reply to Alexis Ballier from comment #9)
> Lars, I think this poppler version should be masked. Fix for texlive is
> definitely non trivial.

Done, see blocker bug.
Comment 12 maurerpe 2017-10-29 18:51:07 UTC
Created attachment 500936 [details, diff]
texlive-poppler-0.59.patch

Patch for texlive-core, borrowed from arch-linux:
https://github.com/archlinuxarm/PKGBUILDs/blob/f9709234223d7fecd210afc29bbe0a5bf037f17e/extra/texlive-bin/texlive-poppler-0.59.patch

The allows texlive to work with the latest poppler: 0.60.1
Comment 13 maurerpe 2017-10-29 18:52:31 UTC
Created attachment 500938 [details]
texlive-core-2017-r3.ebuild

ebuild that applies the patch.  This fixed the issue on my machine.
Comment 14 Alexis Ballier gentoo-dev 2017-11-01 13:21:44 UTC
(In reply to maurerpe from comment #12)
> Created attachment 500936 [details, diff] [details, diff]
> texlive-poppler-0.59.patch
> 
> Patch for texlive-core, borrowed from arch-linux:
> https://github.com/archlinuxarm/PKGBUILDs/blob/
> f9709234223d7fecd210afc29bbe0a5bf037f17e/extra/texlive-bin/texlive-poppler-0.
> 59.patch
> 
> The allows texlive to work with the latest poppler: 0.60.1

Tried it, while it allows to build, the following document triggers random segfaults, deadlocks or assertion errors:

\documentclass{beamer}
\usepackage{graphicx}
\begin{document}
\frame{
\includegraphics[width=1cm]{red}
}
\frame{
\includegraphics[width=1cm]{red}
}
\frame{
\includegraphics[width=1cm]{red}
}
\end{document}



Stick a 'red.pdf' file (any should be good I think) in the same directory and build with pdflatex.
Comment 15 Rafał Mużyło 2017-12-04 22:48:02 UTC
ArchLinux patch has been slightly updated since the version referenced in comment 12. In fact, it was updated long before comment 12 was made.

@comment 14: was your test with the referenced or the updated version ?
Comment 17 Andreas Sturmlechner gentoo-dev 2017-12-20 20:13:50 UTC
Is there any indication this patch is pending upstream?
Comment 18 Andreas Sturmlechner gentoo-dev 2017-12-20 23:10:08 UTC
(In reply to Rafał Mużyło from comment #16)
> https://github.com/archlinuxarm/PKGBUILDs/blob/c87556fca6746dc623690f9c8694e2750fe95298/extra/texlive-bin/texlive-poppler-0.59.patch

Thanks, FWIW this also still builds fine against 0.61.1.
Comment 19 Rafał Mużyło 2017-12-22 22:22:48 UTC
(In reply to Andreas Sturmlechner from comment #18)
> (In reply to comment #16)
> 
> Thanks, FWIW this also still builds fine against 0.61.1.


Well, the part of real interest is not whether it builds, but if the test from comment 14 still fails.

(or if there's another simple test that doesn't involve beamer)
Comment 20 Andreas Sturmlechner gentoo-dev 2017-12-28 18:47:07 UTC
*** Bug 642554 has been marked as a duplicate of this bug. ***
Comment 21 Andreas K. Hüttel archtester gentoo-dev 2017-12-29 00:12:34 UTC
Created attachment 511908 [details, diff]
"updated ArchLinux patch", backported for TL 2016

I've backported the "updated ArchLinux patch" from attachment 509362 [details, diff] to TL 2016, see new attachment. 

Build went fine with poppler 0.61.1. (I have not tested old poppler.)

The beamer test document translates fine with pdflatex and displays with okular as I would expect (three beamer pages with a small embedded pdf).
Comment 22 Juergen Rose 2018-01-06 14:50:43 UTC
(In reply to Andreas K. Hüttel from comment #21)
> Created attachment 511908 [details, diff] [details, diff]
> "updated ArchLinux patch", backported for TL 2016
> 
> I've backported the "updated ArchLinux patch" from attachment 509362 [details, diff]
> [details, diff] to TL 2016, see new attachment. 
> 
> Build went fine with poppler 0.61.1. (I have not tested old poppler.)
> 
> The beamer test document translates fine with pdflatex and displays with
> okular as I would expect (three beamer pages with a small embedded pdf).

Does this patch also work with poppler-0.62.0?
Comment 23 Sebastian Pipping gentoo-dev 2018-01-06 17:43:17 UTC
app-text/texlive-core-2017-r2 has dependencies that prevent this compile error by now (https://github.com/gentoo/gentoo/commit/fe72f5e4dd250d053f0c524d2e26318bab22498f); I'm adjusting the title of the bug because the effect now is blocking system updates to poppler.


(In reply to Juergen Rose from comment #22)
> (In reply to Andreas K. Hüttel from comment #21)
> > Created attachment 511908 [details, diff] [details, diff] [details, diff]
> > "updated ArchLinux patch", backported for TL 2016
> > 
> > I've backported the "updated ArchLinux patch" from attachment 509362 [details, diff] [details, diff]
> > [details, diff] to TL 2016, see new attachment. 
> > 
> > Build went fine with poppler 0.61.1. (I have not tested old poppler.)
> > 
> > The beamer test document translates fine with pdflatex and displays with
> > okular as I would expect (three beamer pages with a small embedded pdf).
> 
> Does this patch also work with poppler-0.62.0?

Thanks, dilfridge!  poppler 0.62.0 is package masked right now anyway, so maybe even 0.61.1 alone would be good enough to move forward with, for now?
Comment 24 Andreas Sturmlechner gentoo-dev 2018-01-06 18:15:54 UTC
I'm sure it built fine with 0.62.0 already (with the patch), no reason to restrict the version for now imo.
Comment 25 Larry the Git Cow gentoo-dev 2018-01-07 05:32:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c622f7c2ea1993a856cb34b707f1b6076cd59725

commit c622f7c2ea1993a856cb34b707f1b6076cd59725
Author:     Alexis Ballier <aballier@gentoo.org>
AuthorDate: 2018-01-07 05:13:10 +0000
Commit:     Alexis Ballier <aballier@gentoo.org>
CommitDate: 2018-01-07 05:13:10 +0000

    app-text/texlive-core: Apply arch linux patch to build with poppler 0.61.
    
    Closes: https://bugs.gentoo.org/629710
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-text/texlive-core/Manifest                    |   1 +
 app-text/texlive-core/texlive-core-2017-r3.ebuild | 359 ++++++++++++++++++++++
 2 files changed, 360 insertions(+)
Comment 26 Alexis Ballier gentoo-dev 2018-01-07 05:34:37 UTC
Thanks all. Merged the 2017 patch and the 2016 backport.

(In reply to Andreas K. Hüttel from comment #21)
> Created attachment 511908 [details, diff] [details, diff]
> "updated ArchLinux patch", backported for TL 2016
> 
> I've backported the "updated ArchLinux patch" from attachment 509362 [details, diff]
> [details, diff] to TL 2016, see new attachment. 


I assume you did this for stable: this is now texlive-core-2016-r6.ebuild in ~arch. I have only barely tested the 2016 version, so I'll need you (or someone else) to champion this in a new stablereq bug. Consider this already acked by me.
Comment 27 Sebastian Pipping gentoo-dev 2018-01-07 20:45:03 UTC
It seems the fix broke compilation against app-text/poppler-0.57.0-r1.  Shall we change the dependency from

  >=app-text/poppler-0.58.0:=

to

  >=app-text/poppler-0.61:=

for a fix?
Comment 28 Sebastian Pipping gentoo-dev 2018-01-07 20:46:36 UTC
Created attachment 513718 [details]
Build log with -r3 error on poppler 0.57.0-r1
Comment 29 Sebastian Pipping gentoo-dev 2018-01-07 20:49:10 UTC
(In reply to Sebastian Pipping from comment #27)
> It seems the fix broke compilation against app-text/poppler-0.57.0-r1. 
> Shall we change the dependency from
> 
>   >=app-text/poppler-0.58.0:=
> 
> to
> 
>   >=app-text/poppler-0.61:=
> 
> for a fix?

I only now noticed this is the fixed version from 
, https://github.com/gentoo/gentoo/commit/a245e9078001ff1bf167390cce9b7797b600440f for bug 643760 already.  So nevermind.
Comment 30 Andreas K. Hüttel archtester gentoo-dev 2018-01-09 22:22:08 UTC
(In reply to Alexis Ballier from comment #26)
> Thanks all. Merged the 2017 patch and the 2016 backport.
> 
> (In reply to Andreas K. Hüttel from comment #21)
> > Created attachment 511908 [details, diff] [details, diff] [details, diff]
> > "updated ArchLinux patch", backported for TL 2016
> > 
> > I've backported the "updated ArchLinux patch" from attachment 509362 [details, diff] [details, diff]
> > [details, diff] to TL 2016, see new attachment. 
> 
> 
> I assume you did this for stable: this is now texlive-core-2016-r6.ebuild in
> ~arch. I have only barely tested the 2016 version, so I'll need you (or
> someone else) to champion this in a new stablereq bug. Consider this already
> acked by me.

Will do, sure.