Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629422 - dev-db/pgadmin3 crashes on startup
Summary: dev-db/pgadmin3 crashes on startup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-31 03:57 UTC by torto09
Modified: 2018-03-21 11:10 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix segfault in pgadmin3 (pgadmin3-fix-segfault.patch,421 bytes, patch)
2017-09-28 22:57 UTC, torto09
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description torto09 2017-08-31 03:57:14 UTC
pgAdmin 3 segfaults when it starts.
After removing the user config file, on the first start it crashes when trying to connect to a server.
This also affects the latest version (1.22.2).

Apparently this is caused by GCC6 optimizations, and can be fixed by:
append-flags '-fno-delete-null-pointer-checks'
(see https://bugzilla.redhat.com/show_bug.cgi?id=1335043)
Comment 1 Jonas Stein gentoo-dev 2017-09-07 07:14:55 UTC
confirmed by upstream bugtracker
Comment 2 Aaron W. Swenson gentoo-dev 2017-09-09 23:30:29 UTC
Please try dev-db/pgadmin4. It will replace dev-db/pgadmin3.
Comment 3 torto09 2017-09-10 20:48:38 UTC
Yes, pgAdmin 4 works fine.
Comment 4 Ștefan Talpalaru 2017-09-28 22:02:53 UTC
Fixed and version bumped to 1.22.2 in my overlay: https://github.com/stefantalpalaru/gentoo-overlay
Comment 5 torto09 2017-09-28 22:57:11 UTC
Created attachment 496986 [details, diff]
Fix segfault in pgadmin3
Comment 6 torto09 2017-09-28 23:00:04 UTC
I believe the attached patch (from Debian) would be a better fix than disabling the optimizations.
Personally, I prefer PgAdmin 3 because it is a native application which does not require QtWebEngine.
Comment 7 Aaron W. Swenson gentoo-dev 2017-10-07 20:43:33 UTC
commit 688f3c389edcf5009d8f5ba5b256a76b75c09ee0 (HEAD -> master, origin/master, origin/HEAD)
Author: Aaron W. Swenson <titanofold@gentoo.org>
Date:   Sat Oct 7 16:42:52 2017 -0400

    dev-db/pgadmin3: Bump to 1.22.2, fix startup crash

    Bump to version 1.22.2.

    Also fix crash on start up when using GCC 6. Thanks torto09.

    Gentoo-Bug: https://bugs.gentoo.org/629422
    Package-Manager: Portage-2.3.8, Repoman-2.3.3
Comment 8 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2017-10-08 08:37:41 UTC
(In reply to Aaron W. Swenson from comment #2)
> Please try dev-db/pgadmin4. It will replace dev-db/pgadmin3.

Only reason I didn't try pgadmin4 already is because it and quasselgrep are not co-installable.

pgadmin4 uses >=dev-python/pycrypto-2.6.1[${PYTHON_USEDEP}]
quasselgrep uses dev-python/pycryptodome[${PYTHON_USEDEP}]

and pycryptodome blocks pycrypto

RDEPEND=" ... !dev-python/pycrypto"

Given both of these tools are used in conjunction with postgres, pgadmin4 is not a viable alternative until something fixes that mutual exclusion.

But whatever the cause you'll have to work it out between you, I don't know how to categorize this as a bug:

> sed -i 's/pycrypto/pycryptodome/g' "${S}"/setup.py || die "sed failed"
Comment 9 Aaron W. Swenson gentoo-dev 2017-10-08 12:25:44 UTC
(In reply to Kent Fredric (IRC: kent\n) from comment #8)
> (In reply to Aaron W. Swenson from comment #2)
> > Please try dev-db/pgadmin4. It will replace dev-db/pgadmin3.
> 
> Only reason I didn't try pgadmin4 already is because it and quasselgrep are
> not co-installable.
> 
> pgadmin4 uses >=dev-python/pycrypto-2.6.1[${PYTHON_USEDEP}]
> quasselgrep uses dev-python/pycryptodome[${PYTHON_USEDEP}]
> 
> and pycryptodome blocks pycrypto
> 
> RDEPEND=" ... !dev-python/pycrypto"
> 
> Given both of these tools are used in conjunction with postgres, pgadmin4 is
> not a viable alternative until something fixes that mutual exclusion.
> 
> But whatever the cause you'll have to work it out between you, I don't know
> how to categorize this as a bug:
> 
> > sed -i 's/pycrypto/pycryptodome/g' "${S}"/setup.py || die "sed failed"

This should probably be a bug for upstream. They're the ones who listed pycrypto as the requirement, and they may be wrong. pycryptodome is supposed to be a drop in replacement [1].

But, the question is, does it supersede pycrypto? I'm leaning towards yes.

[1]: https://github.com/Legrandin/pycryptodome#pycryptodome
Comment 10 Larry the Git Cow gentoo-dev 2018-03-21 11:10:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90665fc12ab36100aa4540faf0ac6f7c488a1df4

commit 90665fc12ab36100aa4540faf0ac6f7c488a1df4
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2018-03-21 11:09:23 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2018-03-21 11:09:55 +0000

    dev-db/pgadmin3: Cleanup
    
    Closes: https://bugs.gentoo.org/629422
    Closes: https://bugs.gentoo.org/630448
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-db/pgadmin3/Manifest                     |  1 -
 dev-db/pgadmin3/files/pgadmin3-desktop.patch | 16 --------
 dev-db/pgadmin3/pgadmin3-1.22.1-r1.ebuild    | 59 ----------------------------
 dev-db/pgadmin3/pgadmin3-1.22.1-r2.ebuild    | 45 ---------------------
 4 files changed, 121 deletions(-)