Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629164 - dev-ruby/bcrypt_pbkdf-1.0.0 fails to merge
Summary: dev-ruby/bcrypt_pbkdf-1.0.0 fails to merge
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-28 11:26 UTC by Willard Dawson
Modified: 2018-04-02 12:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-ruby/bcrypt_pbkdf-1.0.0 emerge fails with undefined reference to SHA512* identifiers (files.zip,46.78 KB, application/x-zip-compressed)
2017-08-28 11:26 UTC, Willard Dawson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Willard Dawson 2017-08-28 11:26:55 UTC
Created attachment 490964 [details]
dev-ruby/bcrypt_pbkdf-1.0.0 emerge fails with undefined reference to SHA512* identifiers

Emerge fails with undefined reference to SHA512* identifiers. Build.log and other files attached.
Comment 1 Hans de Graaff gentoo-dev Security 2017-08-29 05:15:48 UTC
i686-pc-linux-gnu-gcc -I. -I/usr/include/ruby-2.3.0/i686-linux -I/usr/include/ruby-2.3.0/ruby/backward -I/usr/include/ruby-2.3.0 -I. -D_FILE_OFFSET_BITS=64  -fPIC -march=i686 -pipe -fno-strict-aliasing -fPIC  -o hash_sha512.o -c hash_sha512.c
rm -f bcrypt_pbkdf_ext.so
i686-pc-linux-gnu-gcc -shared -o bcrypt_pbkdf_ext.so explicit_bzero.o blowfish.o bcrypt_pbkdf_ext.o bcrypt_pbkdf.o hash_sha512.o -L. -L/usr/lib -L. -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -fstack-protector -rdynamic -Wl,-export-dynamic -Wl,--no-undefined    -lruby23  -lpthread -lgmp -ldl -lcrypt -lm   -lc
bcrypt_pbkdf.o: In function `bcrypt_pbkdf':
bcrypt_pbkdf.c:(.text+0x35f): undefined reference to `SHA512Init'
bcrypt_pbkdf.c:(.text+0x37e): undefined reference to `SHA512Update'
bcrypt_pbkdf.c:(.text+0x396): undefined reference to `SHA512Final'
bcrypt_pbkdf.c:(.text+0x3ec): undefined reference to `SHA512Init'
bcrypt_pbkdf.c:(.text+0x40b): undefined reference to `SHA512Update'
bcrypt_pbkdf.c:(.text+0x42b): undefined reference to `SHA512Update'
bcrypt_pbkdf.c:(.text+0x440): undefined reference to `SHA512Final'
bcrypt_pbkdf.c:(.text+0x4a0): undefined reference to `SHA512Init'
bcrypt_pbkdf.c:(.text+0x4c0): undefined reference to `SHA512Update'
bcrypt_pbkdf.c:(.text+0x4d5): undefined reference to `SHA512Final'
collect2: error: ld returned 1 exit status
make: *** [Makefile:256: bcrypt_pbkdf_ext.so] Error 1
make: Leaving directory '/var/tmp/portage/dev-ruby/bcrypt_pbkdf-1.0.0/work/ruby23/bcrypt_pbkdf-1.0.0/ext/mri'
Comment 2 Hans de Graaff gentoo-dev Security 2017-08-29 05:17:22 UTC
(In reply to Willard Dawson from comment #0)

> Emerge fails with undefined reference to SHA512* identifiers. Build.log and
> other files attached.

In the future could you please upload files separately?
Comment 3 Hans de Graaff gentoo-dev Security 2017-08-29 05:36:05 UTC
(In reply to Hans de Graaff from comment #1)

> bcrypt_pbkdf.c:(.text+0x35f): undefined reference to `SHA512Init'

These methods are defined as "inline void" in a header file, which may be the cause, but I can't reproduce the problem, and thus not confirm possible fixes.
Comment 4 StalkerNOVA 2017-09-24 19:05:40 UTC
https://forums.gentoo.org/viewtopic-p-8121684.html
Same here...
Comment 5 Willard Dawson 2018-03-22 23:21:20 UTC
Any suggestions, then? I'm still having this problem on my old x86 box.
Comment 6 Larry the Git Cow gentoo-dev 2018-04-02 06:55:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6f304336d036d81d199cd4be4a9975ec9840d5e

commit f6f304336d036d81d199cd4be4a9975ec9840d5e
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2018-04-02 06:55:36 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2018-04-02 06:55:36 +0000

    fix compilation when functions are not inlined
    
    Closes: https://bugs.gentoo.org/629164
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-ruby/bcrypt_pbkdf/bcrypt_pbkdf-1.0.0.ebuild | 3 +++
 1 file changed, 3 insertions(+)
Comment 7 Hans de Graaff gentoo-dev Security 2018-04-02 06:56:44 UTC
I don't have an x86 to test this on, but can you confirm that the issue is not fixed and tests still pass?
Comment 8 Willard Dawson 2018-04-02 12:16:24 UTC
I had meant to post my own patches to it, but basically the same - removing "inline" from three type declarations fixes it. I'm away from the x86 system in question this week, but I'm sure it will work (assuming a bit here, not having reviewed the proposed patch).