Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 629112 - app-text/adiff treecleaning candidate
Summary: app-text/adiff treecleaning candidate
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jonas Stein
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2017-08-27 21:43 UTC by Jonas Stein
Modified: 2017-10-03 22:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2017-08-27 21:43:24 UTC
When I wanted to fix a simple typo (#629000), I realized the package has many problems and should rather be cleaned:

There are two versions of adiff in the tree.
adiff-1.4 was forgotten to be deleted after the revbump.

I suggest to treeclean the ebuild, because

* adiff-1.4 has a broken SRC_URI 
* adiff-1.4-r1 uses SRC_URI="mirror://gentoo/${P}" 
* Upstream is dead since a long time
* there are many supported alternatives for the same functionality in the tree
* The ebuild has very low quality
* the ebuild is unmaintained
* no reverse dependencies
* adiff is not available in any other distribution https://repology.org/metapackage/adiff/versions

If anyone needs this tool, I suggest to push it on a public repository, and maintain it there. We can fix the ebuild then.
Comment 1 Jonas Stein gentoo-dev 2017-08-27 21:50:21 UTC
after treecleaning we can remove the blocker in atool:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-arch/atool/atool-0.39.0.ebuild
Comment 2 Jonas Stein gentoo-dev 2017-08-28 17:17:03 UTC
I found a new repository now, so we can also fix it. 
https://github.com/agriffis/adiff
Comment 3 Jonas Stein gentoo-dev 2017-08-29 18:51:49 UTC
After a closer look I realized, that the ebuild, the file from the gentoo mirror and the github repository do all not match together.
Comment 4 Sebastian Pipping gentoo-dev 2017-08-29 19:11:16 UTC
(In reply to Jonas Stein from comment #3)
> After a closer look I realized, that the ebuild, the file from the gentoo
> mirror and the github repository do all not match together.

I don't follow.  app-text/adiff-1.4-r1 installs Perl code (said to be) from 2005 written by Aron Griffis.  So does https://github.com/agriffis/adiff/blob/master/adiff.pl .  What does not match?
Comment 5 Jonas Stein gentoo-dev 2017-08-29 20:33:47 UTC
The package is now masked for removal. The reasons are in my initial post. 
Even Upstream does not run it on Gentoo anymore. 
If anyone really needs this package, please say so.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2017-08-31 08:30:00 UTC
(In reply to Jonas Stein from comment #0)
> When I wanted to fix a simple typo (#629000), I realized the package has
> many problems and should rather be cleaned:
> 
> There are two versions of adiff in the tree.

Which?

> adiff-1.4 was forgotten to be deleted after the revbump.

Easily fixed. Just stabilise -r1 and remove it.

> I suggest to treeclean the ebuild, because
> 
> * adiff-1.4 has a broken SRC_URI 

Fixed in -r1. Just stabilise -r1.

> * adiff-1.4-r1 uses SRC_URI="mirror://gentoo/${P}" 

Easily fixed. Move it to your dev space.

> * Upstream is dead since a long time

Not a problem if the installed software has no problems that upstream should fix.

> * there are many supported alternatives for the same functionality in the
> tree

None of which are mentioned in your package.mask entry.

> * The ebuild has very low quality

Which one? What precisely is wrong?

> * the ebuild is unmaintained

That is no cause for removal unless you can point to grave bugs that are not going to be fixed because it is unmaintained.

> * no reverse dependencies

Oh, so it's *easy* to remove the whole package? If you like low hanging fruits, then why don't you stabilise -r1? 

> * adiff is not available in any other distribution

Apparently comment #2 and comment #4 disagree.

> https://repology.org/metapackage/adiff/versions
> 
> If anyone needs this tool, I suggest to push it on a public repository, and
> maintain it there. We can fix the ebuild then.

Apparently comment #2 and comment #4 suggest a fix.
Comment 7 Jonas Stein gentoo-dev 2017-09-28 16:25:18 UTC
If there is still any user of this package, it would make sense to investigate the version in the gentoo mirror and the different solutions upstream and use the better version. Perhaps it makes sense to switch to the python version, which is old too, but 5 years newer. 
Upstream has no versioned releases any more. 

Do you want to maintain or repair it? 
As we know, the package needs someone in the end who fixes it, and I do not know who will do it, if the package is not used by anybody.
Comment 8 Larry the Git Cow gentoo-dev 2017-10-03 22:12:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=751fabae4578a7c4b8a3afba84188f75cd1b5d12

commit 751fabae4578a7c4b8a3afba84188f75cd1b5d12
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-10-03 22:06:40 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2017-10-03 22:12:29 +0000

    app-text/adiff: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/629112

 app-text/adiff/Manifest            |  1 -
 app-text/adiff/adiff-1.4-r1.ebuild | 43 --------------------------------------
 app-text/adiff/adiff-1.4.ebuild    | 33 -----------------------------
 app-text/adiff/metadata.xml        |  5 -----
 profiles/package.mask              |  6 ------
 5 files changed, 88 deletions(-)