Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 628802 - dev-libs/libcgroup init.d script bugs + enhancement
Summary: dev-libs/libcgroup init.d script bugs + enhancement
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2017-08-24 09:03 UTC by Octavian
Modified: 2023-09-24 22:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Octavian 2017-08-24 09:03:25 UTC
/etc/init.d/cgconfig contains the wrong location for 

WRONG:
CGCLASSIFY="/usr/sbin/cgclassify"
OK:
CGCLASSIFY="/usr/bin/cgclassify"


====================================================

Furthermore, some PID's disappear during classification making the init script to fail if the last PID is such a PID

I would propose the following change

        #local pid
        #for pid in $(ps --no-headers -eL o tid); do
        #       ${CGCLASSIFY} ${pid}
        #done
        ps --no-headers -eL o tid | xargs ${CGCLASSIFY} || echo "Ignoring missing PIDs"

If the dependency of xargs is not desired then 

        ${CGCLASSIFY} ${pid} || echo "Ignoring missing PIDs"

Would make sure we ignore the missing PID's

Best regards,
Octavian
Comment 1 Larry the Git Cow gentoo-dev 2023-09-24 22:12:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=39c69db21c0c4d66fb2685b369b33b5ed3397ff2

commit 39c69db21c0c4d66fb2685b369b33b5ed3397ff2
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2023-09-06 15:02:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-09-24 22:09:56 +0000

    dev-libs/libcgroup: bump 3.1.0, fix CG_CLASSIFY=Yes
    
    Fixes SRC_URI.
    
    Make CG_CLASSIFY=Yes work by adjusting executable path and add parsing
    of /etc/cgroup/cgconfig.d.
    
    Closes: https://bugs.gentoo.org/628802
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/32656
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libcgroup/Manifest                  |   1 +
 dev-libs/libcgroup/files/cgconfig.confd-r2   |   8 ++
 dev-libs/libcgroup/files/cgconfig.initd-r2   |  53 ++++++++++++
 dev-libs/libcgroup/libcgroup-3.0.0-r1.ebuild | 115 +++++++++++++++++++++++++++
 dev-libs/libcgroup/libcgroup-3.1.0.ebuild    | 115 +++++++++++++++++++++++++++
 5 files changed, 292 insertions(+)