Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 628758 - dev-lua/{say,lua_cliargs,dkjson,mediator_lua,luassert,busted}: could include tests
Summary: dev-lua/{say,lua_cliargs,dkjson,mediator_lua,luassert,busted}: could include ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-23 18:45 UTC by Michał Górny
Modified: 2020-12-04 14:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-08-23 18:45:34 UTC
FWICS say-1.3-1/spec/say_spec.lua contains some tests that the package could use.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-08-23 18:49:14 UTC
Oh, -r1 is the revision added by PR#5228 which I'm testing right now. The same applies to -r0.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-08-23 18:56:03 UTC
lua_cliargs: spec/
dkjson: jsontest.lua
mediator_lua: spec/
luassert: spec/
busted (!): spec/
Comment 3 Aric Belsito 2017-08-25 18:25:42 UTC
Alright, going to add tests to say and luassert because those are on the PR I'm trying to get in.
Comment 4 Larry the Git Cow gentoo-dev 2020-11-28 16:17:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d089d1b7118de53261993cec0cac16dc75b4053d

commit d089d1b7118de53261993cec0cac16dc75b4053d
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-11-28 16:15:50 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-11-28 16:16:42 +0000

    dev-lua/busted: migrate to lua eclass
    
    Also adding tests.
    
    Bug: https://bugs.gentoo.org/628758
    Closes: https://bugs.gentoo.org/584694
    Closes: https://bugs.gentoo.org/752921
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 dev-lua/busted/busted-2.0.0-r100.ebuild | 63 +++++++++++++++++++++++++++++++++
 dev-lua/busted/metadata.xml             |  6 +++-
 profiles/package.mask                   |  1 +
 3 files changed, 69 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d54c00c3a0d372f6dcd590b6a4b2ac3badce718

commit 3d54c00c3a0d372f6dcd590b6a4b2ac3badce718
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-11-28 16:10:42 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-11-28 16:16:41 +0000

    dev-lua/dkjson: migrate to lua eclass
    
    Also adding tests.
    
    Bug: https://bugs.gentoo.org/628758
    Closes: https://bugs.gentoo.org/752603
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 dev-lua/dkjson/dkjson-2.5-r100.ebuild | 48 +++++++++++++++++++++++++++++++++++
 dev-lua/dkjson/metadata.xml           |  6 ++++-
 profiles/package.mask                 |  1 +
 3 files changed, 54 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e36ce11c257fb088b5e889c9b68f31ced1eb849b

commit e36ce11c257fb088b5e889c9b68f31ced1eb849b
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-11-28 16:00:16 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-11-28 16:16:38 +0000

    dev-lua/luassert: migrate to lua eclass
    
    Also adding and fixing tests.
    
    Bug: https://bugs.gentoo.org/628758
    Closes: https://bugs.gentoo.org/629658
    Closes: https://bugs.gentoo.org/752936
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 ...uassert-1.8.0-disable-highlightcolor-test.patch | 57 ++++++++++++++++++++++
 dev-lua/luassert/luassert-1.8.0-r100.ebuild        | 55 +++++++++++++++++++++
 dev-lua/luassert/metadata.xml                      |  6 ++-
 profiles/package.mask                              |  1 +
 4 files changed, 118 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16fdc516b77abff5d254a7a452d206be51d8f52b

commit 16fdc516b77abff5d254a7a452d206be51d8f52b
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-11-28 15:49:13 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-11-28 16:16:37 +0000

    dev-lua/mediator_lua: migrate to lua eclass
    
    Also adding tests.
    
    Bug: https://bugs.gentoo.org/628758
    Closes: https://bugs.gentoo.org/752663
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../mediator_lua/mediator_lua-1.1.2_p0-r100.ebuild | 49 ++++++++++++++++++++++
 dev-lua/mediator_lua/metadata.xml                  |  6 ++-
 profiles/package.mask                              |  1 +
 3 files changed, 55 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c12f16cadf77edcecf82bc944a2a15afc1ae2757

commit c12f16cadf77edcecf82bc944a2a15afc1ae2757
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2020-11-28 15:39:07 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-11-28 16:16:35 +0000

    dev-lua/say: migrate to lua eclass
    
    Also adding tests.
    
    Bug: https://bugs.gentoo.org/628758
    Closes: https://bugs.gentoo.org/752945
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 dev-lua/say/metadata.xml           |  4 ++++
 dev-lua/say/say-1.3_p1-r100.ebuild | 48 ++++++++++++++++++++++++++++++++++++++
 profiles/package.mask              |  1 +
 3 files changed, 53 insertions(+)
Comment 5 Conrad Kostecki gentoo-dev 2020-11-28 16:18:39 UTC
(In reply to Michał Górny from comment #2)
> lua_cliargs: spec/

That one is on my todo list, as this needs more deps, which are currently not in tree. But I am on it.

> dkjson: jsontest.lua
> mediator_lua: spec/
> luassert: spec/
> busted (!): spec/

I have now added during lua eclass migration tests for that packages.
Comment 6 Conrad Kostecki gentoo-dev 2020-12-04 14:56:47 UTC
(In reply to Conrad Kostecki from comment #5)
> (In reply to Michał Górny from comment #2)
> > lua_cliargs: spec/
> 
> That one is on my todo list, as this needs more deps, which are currently
> not in tree. But I am on it.

Ok, I think, I close here. There are multiple deps, which would be needed to add tests. I don't think, this is useful for such small package to pull multiple packages into tree for only tests. Let's skip tests for this. So closing here.

Feel free to open, if you don't agree.