Bug 628324 – xfce-base/xfce4-session 4.13.0: segfault when try to Add/Edit Application Autostart Entries

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sergej Petrushkin 2017-08-19 19:25:59 UTC]

xfce4-session-settings 4.13.0 exits with segmentation fault, if press Add or Edit button on Application Autostart tab.

This is known XFCE bug https://bugzilla.xfce.org/show_bug.cgi?id=13271
This patch fixes the problem https://git.xfce.org/xfce/xfce4-session/commit/?id=193b09a9c159d1d16ad69e4298f48c2b531e9392

[Comment 1 Rinaldus 2018-01-10 03:37:14 UTC]

Created attachment 514052 [details, diff]
xfce4-session-4.13.0-autostart_segfault.patch

[Comment 2 Rinaldus 2018-01-10 03:37:47 UTC]

Created attachment 514054 [details]
xfce4-session-4.13.0-r1.ebuild

[Comment 3 Rinaldus 2018-01-10 03:38:46 UTC]

I modified ebuild with patch from git and nothing segfaults now. Everything work properly.

[Comment 4 Jory A. Pratt 2018-01-10 04:11:46 UTC]

(In reply to Rinaldus from comment #3)
> I modified ebuild with patch from git and nothing segfaults now. Everything
> work properly.

You did not need to modify the ebuild, as of eapi 6 you could have just put it into /etc/portage/patches/xfce-base/xfce4-sessions and tested it. I have run the patch for a few months now. Also please make sure you attach the full patch with author info and such, we need to make sure the author gets credit for his/her work.

[Comment 5 Rinaldus 2018-01-10 05:23:26 UTC]

(In reply to Jory A. Pratt from comment #4)
Also please make sure you attach the
> full patch with author info and such, we need to make sure the author gets
> credit for his/her work.

This patch is from Xfce's git upstream. I added information about author inside patch. If I did something wrong, please, fix.

[Comment 6 Rinaldus 2018-01-10 05:24:25 UTC]

Created attachment 514056 [details, diff]
xfce4-session-4.13.0-autostart_segfault.patch

[Comment 7 Michał Górny 2018-01-10 08:47:37 UTC]

Thanks for the reminder. I hoped that upstream would do a new release sooner but since they haven't, I'll proceed with the backport.

[Comment 8 Larry the Git Cow 2018-01-10 09:02:58 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3ce9a81ab6ed752bfd0a5eeee0dd3daf9b920e0

commit b3ce9a81ab6ed752bfd0a5eeee0dd3daf9b920e0
Author:     Michał Górny <[e-mail]>
AuthorDate: 2018-01-10 09:01:51 +0000
Commit:     Michał Górny <[e-mail]>
CommitDate: 2018-01-10 09:02:49 +0000

    xfce-base/xfce4-session: Backport autostart dialog segv fix
    
    Closes: https://bugs.gentoo.org/628324

 ...e4-session-4.13.0-add-edit-autostart-segv.patch | 57 ++++++++++++++++
 .../xfce4-session/xfce4-session-4.13.0-r1.ebuild   | 78 ++++++++++++++++++++++
 2 files changed, 135 insertions(+)