Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 628108 - www-client/midori-0.5.11-r2 : /.../midori-notebook.vala:330.25-330.39: error: Access to non-public constructor Midori.Tally.new denied
Summary: www-client/midori-0.5.11-r2 : /.../midori-notebook.vala:330.25-330.39: error:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-17 16:14 UTC by Toralf Förster
Modified: 2018-05-14 09:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,18.40 KB, text/plain)
2017-08-17 16:14 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,468.39 KB, text/plain)
2017-08-17 16:14 UTC, Toralf Förster
Details
environment (environment,180.81 KB, text/plain)
2017-08-17 16:14 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,26.55 KB, application/x-bzip)
2017-08-17 16:14 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,2.91 KB, application/x-bzip)
2017-08-17 16:14 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,42.04 KB, application/x-bzip)
2017-08-17 16:14 UTC, Toralf Förster
Details
www-client:midori-0.5.11-r2:20170817-030456.log (www-client:midori-0.5.11-r2:20170817-030456.log,10.43 KB, text/plain)
2017-08-17 16:14 UTC, Toralf Förster
Details
vala 0.35 / 0.36 fixes (midori-0.5.11-vala-0.35_0.36.patch,4.86 KB, patch)
2017-09-29 23:15 UTC, Sander Sweers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-08-17 16:14:12 UTC
cd /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11_build/midori && /usr/bin/valac-0.36 -C --header=midori-core.h --library=midori-core --vapi=midori-core.vapi -b /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori -d /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11_build/midori --pkg=posix --pkg=linux --pkg=libxml-2.0 --pkg=sqlite3 --pkg=gmodule-2.0 --pkg=gio-2.0 --pkg=libsoup-2.4 --pkg=gtk+-3.0 --enable-deprecated --debug -D HAVE_EXECINFO_H -D HAVE_LIBSOUP_2_40_0 -D HAVE_LIBSOUP_2_48_0 -D HAVE_GTK3 -D HAVE_WEBKIT2 -D HAVE_WEBKIT2_3_91 /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/../katze/katze-separatoraction.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/../katze/midori-hsts.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/../katze/midori-paths.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/../katze/midori-uri.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-bookmarksdatabase.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-completion.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-contextaction.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-database.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-dialog.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-download.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-extensions-column.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-historycompletion.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-historydatabase.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-notebook.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-panedaction.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-searchcompletion.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-settings.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-speeddial.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-tab.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-viewable.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-viewcompletion.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-window.vala /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/webkit2gtk-4.0.vapi /var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/katze/katze.vapi
/var/tmp/portage/www-client/midori-0.5.11-r2/work/midori-0.5.11/midori/midori-notebook.vala:330.25-330.39: error: Access to non-public constructor `Midori.Tally.new' denied
            var tally = new Tally (tab);
                        ^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-desktop-gnome_20170802-210600

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.4.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python3.6 (fallback)
  [3]   python2.7 (fallback)
  [4]   pypy (fallback)
Available Ruby profiles:
  [1]   ruby21 (with Rubygems)
  [2]   ruby22 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 7.2.6.11 [icedtea-bin-7]
2)	IcedTea JDK 3.5.1 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-7  system-vm
  [2]   icedtea-bin-8 

emerge -qpv www-client/midori
[ebuild  N    ] www-client/midori-0.5.11-r2  USE="jit -doc -granite -xscreensaver -zeitgeist"
Comment 1 Toralf Förster gentoo-dev 2017-08-17 16:14:15 UTC
Created attachment 489392 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-08-17 16:14:19 UTC
Created attachment 489394 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2017-08-17 16:14:22 UTC
Created attachment 489396 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2017-08-17 16:14:25 UTC
Created attachment 489398 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2017-08-17 16:14:28 UTC
Created attachment 489400 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2017-08-17 16:14:32 UTC
Created attachment 489402 [details]
temp.tbz2
Comment 7 Toralf Förster gentoo-dev 2017-08-17 16:14:35 UTC
Created attachment 489404 [details]
www-client:midori-0.5.11-r2:20170817-030456.log
Comment 8 Sander Sweers 2017-09-29 22:47:44 UTC
vala 0.35 appears to break several packages in gentoo. Here is a link to the build fix from upstream. https://bazaar.launchpad.net/~midori/midori/trunk/revision/7159
Comment 9 Sander Sweers 2017-09-29 23:15:21 UTC
Created attachment 497136 [details, diff]
vala 0.35 / 0.36 fixes

But as is fairly common nowadays with gtk project the breakage does not end with 0.35 :(

This patch includes the 0.35 changes and the backwards incompatible (< 0.35 i think) for 0.36
Comment 10 Klaus Kusche 2018-01-06 12:59:07 UTC
(In reply to Sander Sweers from comment #9)
> Created attachment 497136 [details, diff] [details, diff]
> vala 0.35 / 0.36 fixes

Could this please be included in the ebuild?

Due to changes in the portage profiles and the major gcc versions,
a recompile world is required to keep executables compatible
with libraries, and without the patch, midori can't be recompiled.
Comment 11 Alexis Lahouze 2018-01-28 12:30:48 UTC
Hi,

I tried to compile Midori and got this issue.

Tried the patch in attachment #497136 [details, diff] and it compiles.

Any hope to add this patch in portage?
Comment 12 Yevgeny Dyatlov 2018-03-06 12:48:48 UTC
Hi, 
I faced the same problem while compiling www-client/midori-0.5.11-r2.
And after applying patch attachment #497136 [details, diff] it was successfully compiled without errors.
Comment 13 Larry the Git Cow gentoo-dev 2018-05-14 09:18:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=56230de284561aa845115bb3eb64bb18a75b8aa4

commit 56230de284561aa845115bb3eb64bb18a75b8aa4
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-05-14 09:13:42 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-05-14 09:18:06 +0000

    www-client/midori: Support vala-0.36
    
    Closes: https://bugs.gentoo.org/628108

 .../midori/files/midori-0.5.11-vala-0.35.patch     | 101 +++++++++++++++++++++
 www-client/midori/midori-0.5.11-r3.ebuild          |  89 ++++++++++++++++++
 2 files changed, 190 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c19550450727c5b161eaa011e8cd8e5489ec757

commit 1c19550450727c5b161eaa011e8cd8e5489ec757
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-05-14 08:36:07 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-05-14 09:18:02 +0000

    www-client/midori: Limit to vala <= 0.34
    
    Bug: https://bugs.gentoo.org/628108

 www-client/midori/midori-0.5.11-r2.ebuild | 2 ++
 1 file changed, 2 insertions(+)