Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 628078 - sys-boot/plymouth missing dependency xsltproc and should honor USE=-doc
Summary: sys-boot/plymouth missing dependency xsltproc and should honor USE=-doc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2017-08-17 04:54 UTC by Marshall McMullen
Modified: 2017-08-18 04:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed new ebuild honoring USE=doc (plymouth-0.9.2-r1.ebuild,2.50 KB, text/plain)
2017-08-17 04:54 UTC, Marshall McMullen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marshall McMullen 2017-08-17 04:54:09 UTC
Created attachment 489368 [details]
Proposed new ebuild honoring USE=doc

sys-boot fails to build if you do not have xsltproc installed, as in:

checking for IMAGE... yes
checking for UDEV... yes
checking for systemd-tty-ask-password-agent... /usr/bin/systemd-tty-ask-password-agent
checking for udevadm... /usr/bin/udevadm
checking for xsltproc... no
configure: error: xsltproc is required to build documentation

In our use case we do not want to pull in xsltproc. Moreover, all of plymouth assumes you want all its documentation installed which we do not. So I think it should also honor USE=doc and use that to pass in --enable-documentation or --disable-documentation  accordingly.

I've uploaded a suggested new 0.9.2-r1.ebuild which addresses these issues. The diff against the existing 0.9.2.ebuild is as follows:

22:52 :( (130) diff plymouth-0.9.2.ebuild plymouth-0.9.2-r1.ebuild
27c27
< IUSE="debug gdm +gtk +libkms +pango static-libs"
---
> IUSE="debug doc gdm +gtk +libkms +pango static-libs"
30a31
> 	doc? ( dev-libs/libxslt )
67a69
> 		$(use_enable doc documentation)

Please see proposed ebuild.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2017-08-17 22:46:23 UTC
commit 0bb05cf38855b0e72b6ce7c8a16b1401cb70f097
Date:   Fri Aug 18 00:40:26 2017 +0200

    sys-boot/plymouth: fix build with newer glibc, bug #604480
    
    Fix missing dependency on xsltproc and XSL stylesheets as required to
    build man pages, bug #628078.

Thanks for reporting. Unfortunately, xsltproc cannot be made optional as man pages are not considered optional in Gentoo. If you do not wish to have xsltproc installed, just purge build dependencies after the install.
Comment 2 Marshall McMullen 2017-08-18 04:32:55 UTC
That makes sense Gilles. Thanks for fixing the missing dependency issue and explaining the options here for removing xsltproc. Removing build-time dependencies is one of the things on our list to tackle in the coming months.

Thanks.