Bug 627208 – x11-misc/lightdm-gtk-greeter-2.0.1-r1 fails to build with lightdm-1.18.3, too many arguments to function

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Zac Medico 2017-08-06 22:24:09 UTC]

Created attachment 488188 [details]
build log with gcc-5.4.0-r3

The patch from bug 619782 triggers this failure with gcc-5.4.0-r3:

> make[3]: Entering directory '/var/tmp/portage/x11-misc/lightdm-gtk-greeter-2.0.1-r1/work/lightdm-gtk-greeter-2.0.1/src'
>   CC       lightdm_gtk_greeter-lightdm-gtk-greeter.o
>   CC       lightdm_gtk_greeter-greeterbackground.o
>   CC       lightdm_gtk_greeter-greeterconfiguration.o
>   CC       lightdm_gtk_greeter-greetermenubar.o
> lightdm-gtk-greeter.c: In function 'start_authentication':
> lightdm-gtk-greeter.c:1940:9: error: too many arguments to function 'lightdm_greeter_authenticate'
>          lightdm_greeter_authenticate (greeter, NULL, NULL);
>          ^
> In file included from /usr/include/lightdm-gobject-1/lightdm.h:14:0,
>                  from lightdm-gtk-greeter.c:48:
> /usr/include/lightdm-gobject-1/lightdm/greeter.h:128:6: note: declared here
>  void lightdm_greeter_authenticate (LightDMGreeter *greeter, const gchar *username);
>       ^

[Comment 1 Zac Medico 2017-08-06 23:41:36 UTC]

Actually it has nothing to do with gcc. It's the lightdm version.

[Comment 2 Zac Medico 2017-08-07 06:05:37 UTC]

The change occurred in lightdm 1.19.2:

http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/view/head:/NEWS

> Overview of changes in lightdm 1.19.2
> 
>     * Report errors for all liblightdm methods. This will require existing
>       greeters to update their API usage. The ABI is unchanged.

[Comment 3 Zac Medico 2017-08-07 06:07:04 UTC]

This is the breaking revision:

http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/revision/2350

[Comment 4 Zac Medico 2017-08-07 06:40:03 UTC]

Fixed by splitting out a separate patch for lightdm 1.19.2:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b48e290c7510b8cbdf8c9f440b52dd3720d772a4