Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 626710 - app-admin/keepass can display a high resolution icon by capturing WMClass
Summary: app-admin/keepass can display a high resolution icon by capturing WMClass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alessandro Di Federico
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-07-31 15:11 UTC by Brad Laue
Modified: 2018-10-06 10:32 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
keepass-keepass.desktop with defined WM Class (keepass.diff,252 bytes, patch)
2017-07-31 15:11 UTC, Brad Laue
Details | Diff
GNOME screnshot (keepass.png,93.65 KB, image/png)
2017-08-14 13:05 UTC, Brad Laue
Details
GNOME screenshot with WMClass set (keepass-wmclass.png,96.33 KB, image/png)
2017-08-14 13:08 UTC, Brad Laue
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Laue 2017-07-31 15:11:38 UTC
Created attachment 487432 [details, diff]
keepass-keepass.desktop with defined WM Class

Setting StartupWMClass in the XDG desktop file (/usr/share/applications/keepass-keepass.desktop) for app-admin/keepass will display the proper high resolution icon for it. Currently a low-res icon is displayed in hidpi environments. 

The attached diff shows the needed addition.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2017-08-13 04:52:02 UTC
Which desktop do you use? I'm curious to see the difference.
Comment 2 Brad Laue 2017-08-14 13:05:48 UTC
Created attachment 488892 [details]
GNOME screnshot

Hi Michael,

I'm using GNOME 3.22 and Plasma desktops currently on various machines - I'm at a GNOME system now so I've attached a screenshot. 

Brad
Comment 3 Brad Laue 2017-08-14 13:08:17 UTC
Created attachment 488894 [details]
GNOME screenshot with WMClass set

And one of the fixed desktop file. Considerably nicer!
Comment 4 Virgil Dupras (RETIRED) gentoo-dev 2018-09-29 00:21:34 UTC
Alessandro, you're the maintainer of this package. Have you reviewed this patch?
Comment 5 Alessandro Di Federico 2018-09-29 09:10:43 UTC
Sorry for the delay, it works for me. I see green leaf icon if I enabled it, but its higher res.

It can go in.
Comment 6 Virgil Dupras (RETIRED) gentoo-dev 2018-09-29 17:10:10 UTC
The patch is not applicable as-is and needs ebuild work. Maybe think about including it in your next version bump Alessandro.
Comment 7 Larry the Git Cow gentoo-dev 2018-10-06 10:32:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c5bb37bf6ebebec1b9990ee9294ada0cd250ce6

commit 9c5bb37bf6ebebec1b9990ee9294ada0cd250ce6
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2018-10-06 10:31:54 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2018-10-06 10:32:26 +0000

    app-admin/keepass: define WMClass in .desktop file
    
    Closes: https://bugs.gentoo.org/626710
    Signed-off-by: Michael Palimaka <kensington@gentoo.org>
    Package-Manager: Portage-2.3.49, Repoman-2.3.11

 app-admin/keepass/keepass-2.40-r1.ebuild | 111 +++++++++++++++++++++++++++++++
 1 file changed, 111 insertions(+)