Created attachment 487186 [details] Ebuild for screengrab 1.96 The github repository for screengrab has changed from https://github.com/DOOMer/screengrab to https://github.com/QtDesktop/screengrab. Also new versiion are available like the 1.96 release. It uses Qt5 instead of Qt4 and has a dependency on kwindowsystem. I join an ebuild that I wrote and tested for the ~amd64 architecture. It's largely inspired by the 1.2.1 ebuild with dependencies updated.
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: Please update the header and test the ebuild with repoman. EAPI=5 Should be EAPI=6 for new ebuilds. HOMEPAGE=.. is offline?
Just curious, do you know if this is an upstream move or a fork?
(In reply to Jonas Stein from comment #1) > Thank you for your contribution. I had a short look on the ebuild. > Here a few ideas: > > Please update the header and test the ebuild with repoman. > > EAPI=5 > Should be EAPI=6 for new ebuilds. > > HOMEPAGE=.. is offline? Thanks for the advices. I made the changes to the ebuild. Indeed the homepage seems dead but it's still referenced on the Github repository, so for the ebuild I set the HOMEPAGE to the address of the repository. (In reply to Michael Palimaka (kensington) from comment #2) > Just curious, do you know if this is an upstream move or a fork? It seems to be a fork according to : https://github.com/DOOMer/screengrab/issues/53. The original repository has no activity since April 2015.
Created attachment 487336 [details] Ebuild for screengrab 1.96
Nice work. Some observations: 1) version 1.97 is out 2) with SG_GLOBALSHORTCUTS off (the default) SG_USE_SYSTEM_QXT is ignored 3) with 2) and Qt5 the dependency on x11-libs/libqxt isn't needed at all 4) CMake Warning: Manually-specified variables were not used by the project: SG_DOCDIR 5) with 3) and 4) there's no need for local mycmakeargs at all and finally 6) with 5) there's no need for non-default phase functions in the ebuild I tried locally a renamed copy of your 1.96 ebuild with the x11-libs/libqxt dependency and everything after the RDEPEND -line removed, and it builds and installs exactly the same files with the same linkages as it did without the edits. This also allowed me to remove x11-libs/libqxt from my system, thus getting rid of one more Qt4 anchor.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66854f2f1e051919e41c280bae478378067b4788 commit 66854f2f1e051919e41c280bae478378067b4788 Author: Jouni Kosonen <jouni.kosonen@tukesoft.com> AuthorDate: 2017-12-05 13:13:56 +0000 Commit: Michael Palimaka <kensington@gentoo.org> CommitDate: 2017-12-07 10:54:49 +0000 x11-misc/screengrab: Version bump to 1.97 Closes: https://bugs.gentoo.org/626520 Closes: https://github.com/gentoo/gentoo/pull/6450 x11-misc/screengrab/Manifest | 1 + x11-misc/screengrab/metadata.xml | 7 +++--- x11-misc/screengrab/screengrab-1.97.ebuild | 37 ++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+), 4 deletions(-)
