Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 625304 - app-shells/bash: Redundant code in /etc/bash/bashrc
Summary: app-shells/bash: Redundant code in /etc/bash/bashrc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal trivial
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-16 17:10 UTC by setun.90
Modified: 2018-01-04 23:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Replace redundant conditional (bashrc.patch,580 bytes, patch)
2017-07-16 17:12 UTC, setun.90 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description setun.90 2017-07-16 17:10:47 UTC 
The code in /etc/bash/bashrc which sets PS1 when ${use_colors} == false is redundant. A rather frivolous problem, but I am acting in the spirit that code quality is improved a few lines at a time.

Reproducible: Always
Comment 1 setun.90 2017-07-16 17:12:36 UTC 
Created attachment 485106 [details, diff]
Replace redundant conditional
Comment 2 Arfrever Frehtes Taifersar Arahesis 2017-07-17 18:35:30 UTC 
/etc/bash/bashrc belongs to app-shells/bash.
Comment 3 setun.90 2017-07-18 09:57:45 UTC 
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #2)
> /etc/bash/bashrc belongs to app-shells/bash.

Sorry, didn't realize that - should this be migrated then?
Comment 4 Larry the Git Cow gentoo-dev 2018-01-04 23:48:42 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0ad1ef0c4826494a4c8bd00fefd4d55931359fc

commit f0ad1ef0c4826494a4c8bd00fefd4d55931359fc
Author:     Sven Wegener <swegener@gentoo.org>
AuthorDate: 2018-01-04 23:47:58 +0000
Commit:     Sven Wegener <swegener@gentoo.org>
CommitDate: 2018-01-04 23:48:15 +0000

    app-shells/bash: Remove redundant code in bashrc, bug #625304
    
    Closes: https://bugs.gentoo.org/625304
    Package-Manager: Portage-2.3.14, Repoman-2.3.6

 app-shells/bash/files/bashrc | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)