Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624522 - sys-apps/baselayout-2.4.1 does not set "${EPREFIX}/bin" in $PATH for prefix
Summary: sys-apps/baselayout-2.4.1 does not set "${EPREFIX}/bin" in $PATH for prefix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-11 05:03 UTC by nanikata15
Modified: 2017-09-04 10:39 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
profile made with baselayout-2.3 (profile_baselayout-2.3,2.66 KB, text/plain)
2017-07-11 05:04 UTC, nanikata15
Details
00basic made with baselayout-2.3 (00basic_baselayout-2.3,622 bytes, text/plain)
2017-07-11 05:05 UTC, nanikata15
Details
profile made with baselayout-2.4.1 (profile_baselayout-2.4.1,2.27 KB, text/plain)
2017-07-11 05:05 UTC, nanikata15
Details
50baselayout made with baselayout-2.4.1 (50baselayout_baselayout-2.4.1,861 bytes, text/plain)
2017-07-11 05:06 UTC, nanikata15
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nanikata15 2017-07-11 05:03:45 UTC
When baselayout was updated from 2.3 to 2.4.1,
some PATH settings were moved
from /etc/profile to /etc/env.d/50baselayout (former 00basic),
but the ebuild sed commands in src_prepare() that appended
$EPREFIX to necessary paths were not updated, so :/bin: in
50baselayout is left unmodified.

I've attached my profile and 00basic/50baselayout files made with both baselayout versions for comparison.
Comment 1 nanikata15 2017-07-11 05:04:40 UTC
Created attachment 482976 [details]
profile made with baselayout-2.3
Comment 2 nanikata15 2017-07-11 05:05:10 UTC
Created attachment 482978 [details]
00basic made with baselayout-2.3
Comment 3 nanikata15 2017-07-11 05:05:43 UTC
Created attachment 482980 [details]
profile made with baselayout-2.4.1
Comment 4 nanikata15 2017-07-11 05:06:23 UTC
Created attachment 482982 [details]
50baselayout made with baselayout-2.4.1
Comment 5 Guilherme Amadio gentoo-dev 2017-08-09 09:24:00 UTC
Fixed, thanks for reporting!


https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d45b94abca08b1c124e1125375d1c86702fa14b

commit 6d45b94abca08b1c124e1125375d1c86702fa14b
Author: Guilherme Amadio <amadio@gentoo.org>
Date:   Wed Aug 9 11:10:43 2017 +0200

    sys-apps/baselayout: add ${EPREFIX}/bin to $PATH on prefix
    
    Fixes: https://bugs.gentoo.org/624522
    Package-Manager: Portage-2.3.6, Repoman-2.3.3
Comment 6 Benda Xu gentoo-dev 2017-09-04 02:28:46 UTC
Your commit 6d45b94abca08b1c124e11 fails if EPREFIX matches "*/usr*".  I am testing an alternative way to achieve this.
Comment 7 Guilherme Amadio gentoo-dev 2017-09-04 08:52:57 UTC
Oh, bummer. We should probably look into a solution using @GENTOO_PREFIX@ or similar to avoid this sort of problem in the future. It's annoying that sed failres are silent (i.e. only consequence is that $PATH will be wrong). I'm reopening this so we don't forget about it.
Comment 8 Benda Xu gentoo-dev 2017-09-04 10:39:09 UTC
(In reply to Guilherme Amadio from comment #7)
> Oh, bummer. We should probably look into a solution using @GENTOO_PREFIX@ or
> similar to avoid this sort of problem in the future. It's annoying that sed
> failres are silent (i.e. only consequence is that $PATH will be wrong). I'm
> reopening this so we don't forget about it.

No problem.  I have made a commit by using the hprefixify in prefix.eclass.  We can concentrate on elaborating all the corner cases in the eclass and use one implementation on as many ebuilds as possible, so that the sed expression becomes more robust.