Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624160 - x11-terms/terminator-1.91 version bump + stable request
Summary: x11-terms/terminator-1.91 version bump + stable request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal enhancement with 1 vote (vote)
Assignee: Sebastian Pipping
URL: https://launchpad.net/terminator
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks: gnome2-python-removal
  Show dependency tree
 
Reported: 2017-07-07 17:42 UTC by loadaverage
Modified: 2018-02-06 18:39 UTC (History)
11 users (show)

See Also:
Package list:
x11-terms/terminator-1.91
Runtime testing required: ---
stable-bot: sanity-check+


Attachments
terminator-1.91.ebuild (terminator-1.91.ebuild,1.14 KB, text/plain)
2018-01-02 19:37 UTC, Evert
no flags Details
terminator-0.98-r1.ebuild (terminator-0.98-r1.ebuild,1.19 KB, text/plain)
2018-01-12 17:10 UTC, Evert
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description loadaverage 2017-07-07 17:42:52 UTC
Great terminal emulator, but current version (1.0) is too old.

Latest version on https://launchpad.net/terminator/+download is 1.91, and was released 2017-02-26.

Is there any plans to keep terminator up to date?
Comment 1 Jonas Stein gentoo-dev 2017-07-07 19:20:27 UTC
I had a short look. There was a change from gtk2 -> gtk3
Comment 2 Jonas Stein gentoo-dev 2017-07-08 11:34:01 UTC
desktop-misc does not maintain this package anymore. 
There are more recent versions in overlays:
https://gpo.zugaina.org/x11-terms/terminator
Comment 3 Pacho Ramos gentoo-dev 2017-12-06 14:53:54 UTC
We will probably treeclean if nobody steps as a maintainer of this to get the bump done
Comment 4 Rinaldus 2017-12-28 15:19:36 UTC
You can take ebuild for 1.91 version from my overlay (rinaldus-overlay). It's working ebuild, I use it myself. Terminator is the best terminal emulator, because nobody else can split terminal windows as Terminator can.
Comment 5 Arnaud Launay 2017-12-28 19:41:07 UTC
I can confirm that Rinaldus' ebuild just work as a dropin, didn't have to add or modify anything on my local desktop.

Would be nice to continue having terminator.
Comment 6 Reto Gantenbein (ganto) 2017-12-30 12:33:25 UTC
Hmn, I don't think it's that simple. I guess terminator-1.91 should depend on dev-libs/keybinder:3 so that it won't pull in gtk+:2. However, the dev-libs/keybinder:3 ebuild doesn't provide the python bindings.
Comment 7 Ivan Yordanov 2017-12-30 22:02:09 UTC
I use the terminator terminal since I moved to gentoo - about 10 years before. I think it is a great app. I just managed to recompile the terminator application from rinaldus-overlay with no problems. From the .ebuild file we can notice that there is no gnome flag like the old gentoo branch:
the terminator::gentoo ebuild ( old version )-

RDEPEND="
    dev-libs/keybinder:0[python]
    dev-python/psutil
    x11-libs/vte:0[python]
    dbus? ( sys-apps/dbus )
    gnome? (
        dev-python/gconf-python
        dev-python/libgnome-python
        dev-python/pygobject:2[${PYTHON_USEDEP}]
        dev-python/pygtk:2[${PYTHON_USEDEP}]
        )
    libnotify? ( dev-python/notify-python[${PYTHON_USEDEP}] )
"

the /var/lib/layman/rinaldus-overlay/x11-terms/terminator/terminator-1.91.ebuild -
RDEPEND="
    >=x11-libs/gtk+-3.16:3=
    >=dev-libs/glib-2.32:2=
    dev-libs/keybinder:0[python]
    dev-python/psutil
    x11-libs/vte:2.91
    dbus? ( sys-apps/dbus )
    libnotify? ( dev-python/notify-python[${PYTHON_USEDEP}] )
"
so the 1.91 version does not depend on gnome-python libs.
About the keybinder libs - there are 2 slots of this lib in gentoo :
[IP-] [  ] dev-libs/keybinder-0.3.1-r200:0::gentoo
[-P-] [  ] dev-libs/keybinder-0.3.1-r300:3::gentoo

terminator depends on dev-libs/keybinder:0 - I think there is no problem with this.
I think it is time to publish 1.91 as stable version in the ::gentoo branch.
There is no any problem with this package and this application.
Comment 8 Alexander Konotop 2017-12-30 23:17:34 UTC
Hi!
`programmador` is my overlay and as I remember I was first who made 1.91 ebuild.
It works fine for a long time for me.
Actually I wrote the ebuild so long ago that remember nothing about how I did that - most likely I was looking at ubuntu's package dependencies to adapt the same for gentoo.

It's nice too see that there are some more overlays with 1.91 appeared after some time, I think it means that people are really using terminator.
But equery shows that there are really some problems with keybinder which Reto Gantenbein (ganto) mentioned. I didn't try building terminator with keybinder:3 as a dependency.
BTW if I understood right this page
https://github.com/kupferlauncher/keybinder/blob/keybinder-3.0/README
says that python bindings for keybinder 3 do exist actually.
Comment 9 Alexander Konotop 2017-12-30 23:30:01 UTC
Hm, latest ubuntu package has 2 noticable moments:
https://packages.ubuntu.com/bionic/terminator
1. It has a keybinder only as a recommendatio in dependencies list
2. The keybinder version in dependencies is 3.
Comment 10 Tomoya Tabuchi 2017-12-31 02:52:58 UTC
I also have a ebuild for terminator-1.91 that I currently use in my overlay, if anyone is intrested.

https://github.com/tomoyat1/tomoyat1-overlay/blob/master/x11-terms/terminator/terminator-1.91.ebuild
Comment 11 Julien 2018-01-02 12:23:48 UTC
Hello,

it does not work out-of-box on a minimal system, it requires introspection flags on keybinder:3, vte:2.91 and libnotify. Works fine without keybinder:0, no need python flag, introspection is enough.
Please note that libnotify also requires a running dbus daemon


    dev-libs/keybinder:3[introspection]
    x11-libs/vte:2.91[introspection]

    libnotify? (
        dev-python/notify-python[${PYTHON_USEDEP}]
        x11-libs/libnotify[introspection]
        )
Comment 12 Evert 2018-01-02 19:37:10 UTC
Created attachment 512888 [details]
terminator-1.91.ebuild

Other than that, the sed statements don't do anything in version 1.91, so this would be the new ebuild.
Comment 13 Nikolay Kichukov 2018-01-03 15:37:40 UTC
Version-bump it, do not delete it from the main tree.

To those that maintain their overlays or local copies, a maintainer for the package is needed so it remains in ::gentoo, if you are willing to do it, just follow the guidelines defined in the current assignee link in this bug.

Thank you!
-N
Comment 14 Larry the Git Cow gentoo-dev 2018-01-11 23:47:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c150d6ab20f93daf0400a75e2ff9ec035ad6a740

commit c150d6ab20f93daf0400a75e2ff9ec035ad6a740
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2018-01-11 23:42:44 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2018-01-11 23:46:43 +0000

    x11-terms/terminator: 1.91
    
    Bump to prevent removal in entirety
    
    Bug: https://bugs.gentoo.org/624160
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 profiles/package.mask                              |  3 +-
 x11-terms/terminator/Manifest                      |  1 +
 .../terminator/files/terminator-1.91-desktop.patch | 12 ++++
 x11-terms/terminator/terminator-1.91.ebuild        | 67 ++++++++++++++++++++++
 4 files changed, 82 insertions(+), 1 deletion(-)}
Comment 15 Sebastian Pipping gentoo-dev 2018-01-11 23:52:28 UTC
With 1.91 in the tree, shall we ask for stabilization of 1.91 to then remove 0.97-r1, 0.98 and 1.0 in order to unblock bug #640022?
Comment 16 Pacho Ramos gentoo-dev 2018-01-12 14:00:36 UTC
(In reply to Sebastian Pipping from comment #15)
> With 1.91 in the tree, shall we ask for stabilization of 1.91 to then remove
> 0.97-r1, 0.98 and 1.0 in order to unblock bug #640022?

That would be nice, other option could be to simply drop old version... hence moving this to testing and, maybe, in the future, stabilize for main arches if wanted
Comment 17 Evert 2018-01-12 17:10:12 UTC
Created attachment 514492 [details]
terminator-0.98-r1.ebuild

terminator-0.98 is a very stable version which I already use for years because of an issue in 0.97. I suggest to keep this 0.98-r1 ebuild which basically is the same as 0.98 with the gnome part removed so it won't block the removal of old gnome-python packages anymore.
Comment 18 Sebastian Pipping gentoo-dev 2018-01-14 16:53:33 UTC
(In reply to Evert from comment #17)
> terminator-0.98 is a very stable version which I already use for years
> because of an issue in 0.97. I suggest to keep this 0.98-r1 ebuild which
> basically is the same as 0.98 with the gnome part removed so it won't block
> the removal of old gnome-python packages anymore.

We can only keep releases maintained upstream, especially when thinking security.  Please give 1.91 a shot and open bugs about anything broken you run into so it gets fixed in Gentoo and upstream and hence for everyone else, too.  Thanks!


(In reply to Pacho Ramos from comment #16)
> That would be nice, other option could be to simply drop old version...
> hence moving this to testing and, maybe, in the future, stabilize for main
> arches if wanted

I'd favor stabilization with an app as popular as this.
Adding arch teams for stabilization of 1.91: amd64 x86
Comment 19 Larry the Git Cow gentoo-dev 2018-01-28 01:35:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=845b2d81e6eb9e842bd9450e5adc0be12e75ef01

commit 845b2d81e6eb9e842bd9450e5adc0be12e75ef01
Author:     Mikle Kolyada <zlogene@gentoo.org>
AuthorDate: 2018-01-28 01:35:02 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2018-01-28 01:35:02 +0000

    x11-terms/terminator: Drop old
    
    Bug: https://bugs.gentoo.org/624160
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 x11-terms/terminator/Manifest                      |  3 -
 x11-terms/terminator/files/0.94-session.patch      | 13 ----
 .../files/terminator-0.97-brightness.patch         | 35 ----------
 .../terminator/files/terminator-1.0-desktop.patch  | 11 ----
 x11-terms/terminator/terminator-0.97-r1.ebuild     | 62 ------------------
 x11-terms/terminator/terminator-0.98.ebuild        | 73 ---------------------
 x11-terms/terminator/terminator-1.0.ebuild         | 76 ----------------------
 7 files changed, 273 deletions(-)}
Comment 20 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-01-28 12:53:42 UTC
amd64 stable
Comment 21 Thomas Deutschmann (RETIRED) gentoo-dev 2018-02-06 18:39:01 UTC
x86 stable, closing