Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 623142 - x11-drivers/xf86-video-amdgpu fails to build without USE=glamor
Summary: x11-drivers/xf86-video-amdgpu fails to build without USE=glamor
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-30 04:58 UTC by Stuart Longland
Modified: 2017-11-25 20:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log for version 1.3.0 (build.log,28.22 KB, text/x-log)
2017-06-30 04:58 UTC, Stuart Longland
Details
emerge --info (file_623142.txt,6.85 KB, text/plain)
2017-06-30 05:00 UTC, Stuart Longland
Details
build log for version 1.4.0 (build.log,28.62 KB, text/plain)
2017-10-09 16:28 UTC, Matthew Marchese
Details
emerge --info for amdgpu-1.4.0 (info,4.99 KB, text/plain)
2017-10-09 16:29 UTC, Matthew Marchese
Details
emerge -pqv '=x11-drivers/xf86-video-amdgpu-1.4.0::gentoo' (emerge,180 bytes, text/plain)
2017-10-09 16:29 UTC, Matthew Marchese
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Longland 2017-06-30 04:58:48 UTC
Created attachment 478436 [details]
build log for version 1.3.0

If one tries to install the amdgpu driver without USE=glamor, they get a log like the following:

libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/x11-drivers/xf86-video-amdgpu-1.3.0/work/xf86-video-amdgpu-1.3.0/src -I.. -Wall -I/usr/include/libdrm -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/X11/dri -O2 -pipe -c /var/tmp/portage/x11-drivers/xf86-video-amdgpu-1.3.0/work/xf86-video-amdgpu-1.3.0/src/drmmode_display.c  -fPIC -DPIC -o .libs/drmmode_display.o
libtool: compile:  x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/x11-drivers/xf86-video-amdgpu-1.3.0/work/xf86-video-amdgpu-1.3.0/src -I.. -Wall -I/usr/include/libdrm -fvisibility=hidden -I/usr/include/xorg -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/X11/dri -O2 -pipe -c /var/tmp/portage/x11-drivers/xf86-video-amdgpu-1.3.0/work/xf86-video-amdgpu-1.3.0/src/amdgpu_pixmap.c  -fPIC -DPIC -o .libs/amdgpu_pixmap.o
In file included from ESC[01mESC[K/var/tmp/portage/x11-drivers/xf86-video-amdgpu-1.3.0/work/xf86-video-amdgpu-1.3.0/src/amdgpu_dri2.c:34:0ESC[mESC[K:
ESC[01mESC[K/var/tmp/portage/x11-drivers/xf86-video-amdgpu-1.3.0/work/xf86-video-amdgpu-1.3.0/src/amdgpu_glamor.h:33:20:ESC[mESC[K ESC[01;31mESC[Kfatal error: ESC[mESC[Kglamor.h: No such file or directory
compilation terminated.

Both 1.3.0 and 1.2.0 are affected.  For now, I've just set USE=glamor, it was unset due to that being the default for my profile.
Comment 1 Stuart Longland 2017-06-30 05:00:29 UTC
Created attachment 478438 [details]
emerge --info
Comment 2 Ryan Harris 2017-08-14 21:21:29 UTC
I can confirm the same problem building without USE="glamor". It apparently still looks for the header file
Comment 3 Stuart Longland 2017-08-16 12:51:13 UTC
I haven't been able to rule out the possibility that amdgpu requires glamor support… implying the USE flag should be removed.
Comment 4 Matthew Marchese Gentoo Infrastructure gentoo-dev 2017-10-09 16:28:11 UTC
Created attachment 498238 [details]
build log for version 1.4.0

Here's my build.log for version 1.4.0.
Comment 5 Matthew Marchese Gentoo Infrastructure gentoo-dev 2017-10-09 16:29:04 UTC
Created attachment 498240 [details]
emerge --info for amdgpu-1.4.0

Here's emerge --info for version 1.4.0.
Comment 6 Matthew Marchese Gentoo Infrastructure gentoo-dev 2017-10-09 16:29:42 UTC
Created attachment 498242 [details]
emerge -pqv '=x11-drivers/xf86-video-amdgpu-1.4.0::gentoo'
Comment 7 Larry the Git Cow gentoo-dev 2017-11-25 20:10:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e160452bbef03efa6284dcc3cb948a1462abf3f5

commit e160452bbef03efa6284dcc3cb948a1462abf3f5
Author:     Nick Sarnie <commendsarnex@gmail.com>
AuthorDate: 2017-11-24 15:29:34 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2017-11-25 20:08:49 +0000

    x11-drivers/xf86-video-amdgpu: Remove glamor USE flag
    
    Glamor is required as per Michel Dänzer and Dave Airlie
    
    Closes: https://github.com/gentoo/gentoo/pull/6283
    Closes: https://bugs.gentoo.org/623142
    Signed-off-by: Nick Sarnie <commendsarnex@gmail.com>

 x11-drivers/xf86-video-amdgpu/metadata.xml                   | 3 ---
 x11-drivers/xf86-video-amdgpu/xf86-video-amdgpu-1.3.0.ebuild | 6 ++----
 x11-drivers/xf86-video-amdgpu/xf86-video-amdgpu-1.4.0.ebuild | 6 ++----
 x11-drivers/xf86-video-amdgpu/xf86-video-amdgpu-9999.ebuild  | 6 ++----
 4 files changed, 6 insertions(+), 15 deletions(-)
Comment 8 Matt Turner gentoo-dev 2017-11-25 20:16:01 UTC
Just to be clear, we removed the glamor USE flag and made it always enabled. We also changed the default setting for xorg-server's glamor USE flag to be enabled by default.