Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622980 - www-client/qutebrowser ebuild should offer option to install user scripts
Summary: www-client/qutebrowser ebuild should offer option to install user scripts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tim Harder
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2017-06-29 03:54 UTC by Bearcat M. Şándor
Modified: 2019-03-11 14:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild that allows installing userscripts (qutebrowser-1.5.2-r1.ebuild,2.03 KB, text/plain)
2019-02-12 15:35 UTC, max
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bearcat M. Şándor 2017-06-29 03:54:01 UTC
The ebuild for qutebrowser should have a useflag to enable the installation of the included scripts in the codebase.

These scripts can be found at https://github.com/qutebrowser/qutebrowser/tree/4ec5700cbf9ced71c24d57de3ddcae102c9116c0/misc/userscripts

Reproducible: Always

Steps to Reproduce:
1.Emerge qutebrowser (any version)
2.
3.
Actual Results:  
qutebrowser is installed with no userscripts

Expected Results:  
There should be a 'scripts' useflag available

when using a 'scripts' useflag the scripts should be installed with the program
Comment 1 Bearcat M. Şándor 2017-06-29 03:54:55 UTC
If i can figure out how to do this myself, i'll do it and submit the resulting ebuild.
Comment 2 Sam Stone 2018-03-09 15:20:44 UTC
I'm having the same issue. As a result I can't install any dictionary.
Comment 3 Justin Bronder (RETIRED) gentoo-dev 2018-03-09 17:24:43 UTC
(In reply to Sam Stone from comment #2)
> I'm having the same issue. As a result I can't install any dictionary.

For spell check at least, you probably want https://github.com/gentoo/qt/pull/164
Comment 4 max 2019-02-12 15:35:01 UTC
I've made a modification the ebuild for qutebrowser version 1.5.2-r1 that installs userscripts to `/usr/share/qutebrowser/userscripts` if the scripts use flag is set.

I've tried to do this in a way that I think is as canonical as possible.  Feel free to criticise/modify/use.
Comment 5 max 2019-02-12 15:35:54 UTC
Created attachment 564940 [details]
Proposed ebuild that allows installing userscripts
Comment 6 Larry the Git Cow gentoo-dev 2019-03-11 14:11:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ddd3840a7b57e788682771b2b769608d0aa848b5

commit ddd3840a7b57e788682771b2b769608d0aa848b5
Author:     Maximilian Friedersdorff <max@friedersdorff.com>
AuthorDate: 2019-02-14 10:55:15 +0000
Commit:     Justin Bronder <jsbronder@gentoo.org>
CommitDate: 2019-03-11 14:10:24 +0000

    www-client/qutebrowser: Add scripts use flag
    
    Closes: https://bugs.gentoo.org/622980
    Package-Manager: Portage-2.3.60, Repoman-2.3.12
    Signed-off-by: Maximilian Friedersdorff <max@friedersdorff.com>
    Signed-off-by: Justin Bronder <jsbronder@gentoo.org>

 www-client/qutebrowser/metadata.xml                |  4 ++++
 www-client/qutebrowser/qutebrowser-1.5.2-r1.ebuild | 13 ++++++++++++-
 www-client/qutebrowser/qutebrowser-1.6.0.ebuild    | 13 ++++++++++++-
 www-client/qutebrowser/qutebrowser-9999.ebuild     | 13 ++++++++++++-
 4 files changed, 40 insertions(+), 3 deletions(-)