Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622470 - app-editors/atom-1.18.0 bump request
Summary: app-editors/atom-1.18.0 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Elvis Pranskevichus
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 13:14 UTC by Jakub Caban
Modified: 2017-06-30 12:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
FAILING ebuild (atom-1.18.0.ebuild,10.99 KB, text/plain)
2017-06-22 13:14 UTC, Jakub Caban
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Caban 2017-06-22 13:14:55 UTC
Created attachment 477600 [details]
FAILING ebuild

Atom moved quite a bit since version 1.16 that is available on Gentoo:

https://atom.io/releases

It would be great to have them on gentoo. I've tried bumping locally, but couldn't get through it. I'm attaching my failed attempt.

It fails on:
make: Leaving directory '/tmp/portage/app-editors/atom-1.18.0/work/superstring-1.1.0/build'
gyp info ok 
cp: cannot stat '/tmp/portage/app-editors/atom-1.18.0/work/atom-1.18.0/build/modules/nsfw/nsfw.node': No such file or directory

If I could get a hint on that one I can try to work on this :)
Comment 1 Dennis Schridde 2017-06-27 15:05:31 UTC
1.17.2 would be a useful intermediate step, in case 1.18.0 turns out to be difficult to do.
Comment 2 Elvis Pranskevichus 2017-06-27 19:11:09 UTC
I pushed 1.18.0 to the atom overlay.  Please test, I'll make a PR soon.
Comment 3 Elvis Pranskevichus 2017-06-27 19:18:51 UTC
https://github.com/gentoo/gentoo/pull/4999
Comment 4 Patrice Clement gentoo-dev 2017-06-30 12:23:59 UTC
commit b99293046515c6f305e797e607d8c1a75c717fbe (HEAD -> master, origin/master, origin/HEAD)
Author:     Elvis Pranskevichus <elvis@magic.io>
AuthorDate: Tue Jun 27 15:14:32 2017 -0400
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Fri Jun 30 14:22:58 2017 +0200

app-editors/atom: version bump to 1.18.0.

Gentoo-Bug: https://bugs.gentoo.org/622470

Package-Manager: Portage-2.3.6, Repoman-2.3.1
Closes: https://github.com/gentoo/gentoo/pull/4999

app-editors/atom/Manifest           |   7 +
app-editors/atom/atom-1.18.0.ebuild | 412 ++++++++++++++++++++++++++++++++++++
2 files changed, 419 insertions(+)
create mode 100644 app-editors/atom/atom-1.18.0.ebuild

Merged, thanks!
Comment 5 Jakub Caban 2017-06-30 12:29:58 UTC
Don't we also need electron-1.3.15 as per https://github.com/atom/atom/pull/14293 ?

I see 1.3.13 as newest in portage/atom overlay in 1.3 line.

I will surely test this build during weekend, as it takes half a day to merge electron here.