Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622434 - media-libs/libvisual-plugins updated to use virtual/jack
Summary: media-libs/libvisual-plugins updated to use virtual/jack
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: virtual/jack-tracker
  Show dependency tree
 
Reported: 2017-06-22 01:19 UTC by Bearcat M. Şándor
Modified: 2020-07-31 11:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed ebuild (libvisual-plugins-0.4.0-r3.ebuild,1.88 KB, text/plain)
2017-06-22 01:21 UTC, Bearcat M. Şándor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bearcat M. Şándor 2017-06-22 01:19:42 UTC
Updated the build file to use virtual/jack.
ebuild attached.

Reproducible: Always
Comment 1 Bearcat M. Şándor 2017-06-22 01:21:34 UTC
Created attachment 477580 [details]
Fixed ebuild
Comment 2 Jonas Stein gentoo-dev 2017-06-24 18:54:56 UTC
Thank you for your contribution. 

Some ideas:

please test the ebuild with repoman. 
https://wiki.gentoo.org/wiki/Repoman#Usage

I suggest to bump to EAPI=6

Keywords should be ~...
https://devmanual.gentoo.org/keywording/
Comment 3 jannis 2019-09-27 20:39:13 UTC
PR is open since several weeks. Would the Gentoo Sound team please mind to review and merge it? Thanks :)
Comment 4 jannis 2020-07-31 09:36:44 UTC
Hi, this is still an issue for me, blocking the switchover from media-sound/jack-audio-connection-kit-0.125.0:0/0::gentoo to media-sound/jack2-1.9.14:2/2::gentoo....

It's a very subtle change in the dependencies and I've also bumped the EAPI to 7 instead of 6 as proposed by jstein on 2017-06-24....

What's blocking the PR to be merged?
Comment 5 Larry the Git Cow gentoo-dev 2020-07-31 11:04:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a0000ce9816be9a732c0c4350564dab9f8aecd4

commit 7a0000ce9816be9a732c0c4350564dab9f8aecd4
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-07-31 11:03:56 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-07-31 11:04:11 +0000

    media-plugins/libvisual-plugins: switched to virtual/jack and eapi7
    
    used patch from Jannis Achstetter <kripton@kripserver.net>
    with some modifications
    
    Closes: https://github.com/gentoo/gentoo/pull/12454
    Closes: https://bugs.gentoo.org/622434
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../libvisual-plugins-0.4.0-r4.ebuild              | 79 ++++++++++++++++++++++
 1 file changed, 79 insertions(+)