Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622254 - sci-mathematics/rstudio-1.1.273 bump request
Summary: sci-mathematics/rstudio-1.1.273 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mark Wright
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-19 21:08 UTC by Jonas Stein
Modified: 2017-12-03 15:58 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for rstudio-1.1.318 applying rstudio-1.1.318-clang-pandoc.patch (rstudio-1.1.318.ebuild,8.12 KB, text/plain)
2017-08-03 10:31 UTC, Bernd Feige
Details
Updated patch to remove in-tree clang and pandoc. (rstudio-1.1.318-clang-pandoc.patch,3.29 KB, patch)
2017-08-03 10:32 UTC, Bernd Feige
Details | Diff
Patch to fixe Trace.cpp compilation. (rstudio-1.1.357-boost.patch,300 bytes, patch)
2017-09-13 07:53 UTC, Bernd Feige
Details | Diff
Updated patch to remove in-tree clang and pandoc (rstudio-1.1.357-clang-pandoc.patch,3.16 KB, patch)
2017-09-16 14:32 UTC, Bernd Feige
Details | Diff
Ebuild for rstudio-1.1.365 applying current patches (rstudio-1.1.365.ebuild,8.17 KB, patch)
2017-09-16 14:34 UTC, Bernd Feige
Details | Diff
Ebuild for rstudio-1.1.368 applying current patches (rstudio-1.1.368.ebuild,8.17 KB, text/plain)
2017-09-16 18:12 UTC, Bernd Feige
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Mark Wright gentoo-dev 2017-07-24 04:31:37 UTC
I bumped it to 1.0.153 which is the latest version listed here:

https://www.rstudio.com/products/rstudio/release-notes/

Which gives me the impression that the releases tagged in github that are not mentioned in the release notes page above are not official releases, but rather just alpha or development versions?
Comment 2 Volkmar Glauche 2017-07-31 06:52:33 UTC
See also bug #626062 - apparently only rstudio 1.1.x is compatible with R 3.4 and above.
Comment 3 Bernd Feige 2017-08-03 10:31:24 UTC
Created attachment 487784 [details]
Ebuild for rstudio-1.1.318 applying rstudio-1.1.318-clang-pandoc.patch

Here's the ebuild for the new version. I updated the patch removing in-tree clang and pandoc to the current version, no other changes.
Comment 4 Bernd Feige 2017-08-03 10:32:06 UTC
Created attachment 487786 [details, diff]
Updated patch to remove in-tree clang and pandoc.
Comment 5 Bernd Feige 2017-08-03 11:01:09 UTC
(In reply to Bernd Feige from comment #3)
> Created attachment 487784 [details]
> Ebuild for rstudio-1.1.318 applying rstudio-1.1.318-clang-pandoc.patch

... Also works cleanly with current 1.1.324 BTW, just rename the ebuild - very quick with releases they are ;-)
Comment 6 Carl W. Harlow 2017-08-03 13:01:51 UTC
thanks Bernd worked for me
Comment 7 Rolf S. Arvidson 2017-08-03 16:47:00 UTC
Thanks Bernd, your patch and ebuild (rstudio-1.1.318.ebuild) also worked for me. Best //rolf
Comment 8 Oleg 2017-08-03 20:27:09 UTC
(In reply to Bernd Feige from comment #3)
> Created attachment 487784 [details]
> Ebuild for rstudio-1.1.318 applying rstudio-1.1.318-clang-pandoc.patch
> 
> Here's the ebuild for the new version. I updated the patch removing in-tree
> clang and pandoc to the current version, no other changes.

It's should depend on >=dev-libs/boost-1.63:=
Comment 9 Alex 2017-09-13 07:46:39 UTC
Doesn't work for 1.1.318:


<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
<built-in>: note: this is the location of the previous definition
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
/var/tmp/portage/sci-mathematics/rstudio-1.1.318/work/rstudio-1.1.318/src/cpp/core/Trace.cpp: In function ‘void rstudio::core::trace::add(void*, const string&)’:
/var/tmp/portage/sci-mathematics/rstudio-1.1.318/work/rstudio-1.1.318/src/cpp/core/Trace.cpp:40:7: error: ‘cerr’ is not a member of ‘std’
       std::cerr << key << "      " << functionName << std::endl;
       ^~~
Comment 10 Bernd Feige 2017-09-13 07:52:14 UTC
(In reply to Alex from comment #9)
> Doesn't work for 1.1.318:
> 
> 
> <command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
> <built-in>: note: this is the location of the previous definition
>     [javac] Note: Some input files use or override a deprecated API.
>     [javac] Note: Recompile with -Xlint:deprecation for details.
> /var/tmp/portage/sci-mathematics/rstudio-1.1.318/work/rstudio-1.1.318/src/
> cpp/core/Trace.cpp: In function ‘void rstudio::core::trace::add(void*, const
> string&)’:
> /var/tmp/portage/sci-mathematics/rstudio-1.1.318/work/rstudio-1.1.318/src/
> cpp/core/Trace.cpp:40:7: error: ‘cerr’ is not a member of ‘std’
>        std::cerr << key << "      " << functionName << std::endl;
>        ^~~

I encountered the same problem, we need the attached patch (just including iostream at the beginning of Trace.cpp).
Comment 11 Bernd Feige 2017-09-13 07:53:12 UTC
Created attachment 494306 [details, diff]
Patch to fixe Trace.cpp compilation.
Comment 12 Alex 2017-09-13 08:53:19 UTC
(In reply to Bernd Feige from comment #11)
> Created attachment 494306 [details, diff] [details, diff]
> Patch to fixe Trace.cpp compilation.

Works like a charm on 1.1.318, thank you.
Comment 13 Carl W. Harlow 2017-09-16 00:19:41 UTC
where in the list of patches does this new one go? I added it after the clang-pandoc one in the ebuild but now it dies at the clang-pandoc patch. Have been OK with 1.1.318 then 1.1.324. I upgraded boost to 1.65 and now that will not rebuild so I came back to this page.

Maybe I did something else wrong? I renamed the ebuild just like before, then added the new boost patch at *

PATCHES=(
		"${FILESDIR}/${PN}-0.99.879-prefs.patch"
		"${FILESDIR}/${PN}-1.0.44-paths.patch"
		"${FILESDIR}/${PN}-1.1.318-clang-pandoc.patch"
	    --> *
                "${FILESDIR}/${PN}-0.98.490-linker_flags.patch"
		"${FILESDIR}/${PN}-0.98.1091-boost-1.57.patch"
		"${FILESDIR}/${PN}-0.99.473-qtsingleapplication.patch"
		"${FILESDIR}/${PN}-1.0.44-systemd.patch"
)

but like I said, now it dies at this previous patch.

so I guess it looks like this

PATCHES=(
		"${FILESDIR}/${PN}-0.99.879-prefs.patch"
		"${FILESDIR}/${PN}-1.0.44-paths.patch"
		"${FILESDIR}/${PN}-1.1.318-clang-pandoc.patch"
                "${FILESDIR}/${PN}-1.1.357-boost.patch"
		"${FILESDIR}/${PN}-0.98.490-linker_flags.patch"
		"${FILESDIR}/${PN}-0.98.1091-boost-1.57.patch"
		"${FILESDIR}/${PN}-0.99.473-qtsingleapplication.patch"
		"${FILESDIR}/${PN}-1.0.44-systemd.patch"
)

any advice would be appreciated. Thanks for the help thus far!!
Comment 14 Bernd Feige 2017-09-16 14:32:28 UTC
Created attachment 494752 [details, diff]
Updated patch to remove in-tree clang and pandoc
Comment 15 Bernd Feige 2017-09-16 14:34:02 UTC
Created attachment 494754 [details, diff]
Ebuild for rstudio-1.1.365 applying current patches
Comment 16 Bernd Feige 2017-09-16 14:35:32 UTC
(In reply to Carl W. Harlow from comment #13)
> where in the list of patches does this new one go? I added it after the
> clang-pandoc one in the ebuild but now it dies at the clang-pandoc patch.
> Have been OK with 1.1.318 then 1.1.324. I upgraded boost to 1.65 and now
> that will not rebuild so I came back to this page.
> 
> Maybe I did something else wrong? I renamed the ebuild just like before,
> then added the new boost patch at *

Sorry, clang-pandoc.patch needs to be updated as well. I updated ebuild and patches now...
Comment 17 Bernd Feige 2017-09-16 18:12:40 UTC
Created attachment 494772 [details]
Ebuild for rstudio-1.1.368 applying current patches

Updated ebuild for current 1.1.368, now got around to update the boost dependency as per oleg's advice.
Comment 18 Carl W. Harlow 2017-09-17 07:23:45 UTC
thanks very much Bernd I appreciate it!
Comment 19 Sobhan Mohammadpour (RETIRED) gentoo-dev 2017-10-08 17:31:38 UTC
(In reply to Bernd Feige from comment #17)
> Created attachment 494772 [details]
> Ebuild for rstudio-1.1.368 applying current patches
> 
> Updated ebuild for current 1.1.368, now got around to update the boost
> dependency as per oleg's advice.

It would be nice if you made a merge request.
Cheers Sobhan
Comment 20 Mark Wright gentoo-dev 2017-10-24 07:22:05 UTC
Bumped, thanks:

ommit a36219a (HEAD -> master, origin/master, origin/HEAD)
Author: Sobhan Mohammadpour www.sobhan.mohammadpour@gmail.com
Date: Mon Oct 23 15:58:39 2017 +0330

sci-mathematics/rstudio: version bump to 1.1.368

Bump to 1.1.368. This also updates the clang pandoc patch
Fixes bug 626056, thanks to Harris Landgarten for reporting, Sobhan
Mohammadpour for adding the missing dependency in 1.1.383.
Fixes bug 626062 by bumping rstudio to version 1.1.383 that builds with R 3.4.
Thanks to Harris Landgarten for reporting, jstein, Volkmar Glauche, Bernd
Feige and yuri for testing and helping, Sobhan Mohammadpour for bumping
rstudio in PR #6003.
Fixes bug 622254, thanks to jstein for reporting, Volkmar Glauche, Bernd Feige,
Carl W. Harlow, Rolf S. Arvidson, Oleg, Alex and Sobhan Mohammadpour for
testing and helping.
Fixes bug 633936, thanks to Neil for reporting, Fran<C3><A7>ois Valenduc and Bernd
for helping.

Suggested-by: Bernd Feige <Bernd.Feige@gmx.net>
Gentoo-bug: 626056, 626062. 622254, 633936
Comment 21 Larry the Git Cow gentoo-dev 2017-12-03 15:58:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fcb31051b785dc5e617e418073f07eedfcc8a1b

commit 3fcb31051b785dc5e617e418073f07eedfcc8a1b
Author:     Bernd Waibel <waebbl@gmail.com>
AuthorDate: 2017-11-07 19:54:42 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2017-12-03 15:57:44 +0000

    sci-mathematics/rstudio: version bump to 1.1.383
    
    Ebuild is based on https://bugs.gentoo.org/attachment.cgi?id=494772
    and the published rstudio-1.1.368.ebuild file.
    
    files/rstudio-0.98.1091-boost-1.57.patch: removed from patches, it's no
    longer possible to apply this patch, due to changes     in
    src/cpp/desktop/DesktopApplicationLaunch.hpp (see
    https://github.com/rstudio/rstudio/commit/585f7244797814d969418d8fe795d1952d84f6df)
    which added an #include <QProcess> statement which lets the patch fail.
    
    Thanks to Bernd Feige <Bernd.Feige@gmx.net> for the initial ebuild
    and a17r on github for his suggestions on my first try to create a
    PR for this.
    
    Bug: https://bugs.gentoo.org/633936
    Bug: https://bugs.gentoo.org/622254
    
    Reported-by: Neil <nshephard@gmail.com> (#633936)
    Reported-by: Jonas Stein <jstein@gentoo.org> (#622254)
    
    Package Manager: portage-2.3.13 repoman-2.3.4
    Closes: https://github.com/gentoo/gentoo/pull/6145

 sci-mathematics/rstudio/Manifest               |   1 +
 sci-mathematics/rstudio/rstudio-1.1.383.ebuild | 247 +++++++++++++++++++++++++
 2 files changed, 248 insertions(+)}