Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 621978 - media-libs/opus - error Cannot build libopus with -ffast-math unless FLOAT_APPROX is defined. This could result in crashes on extreme (e.g. NaN) input
Summary: media-libs/opus - error Cannot build libopus with -ffast-math unless FLOAT_AP...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2017-06-16 22:30 UTC by C. Wijtmans
Modified: 2019-05-22 01:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description C. Wijtmans 2017-06-16 22:30:14 UTC 
add -fno-fast-math or FLOAT_APPROX?
Comment 1 CGordon 2017-12-14 19:13:02 UTC 
A local flag for the "--fast-float-approx" option (FLOAT_APPROX) would be fine.
Comment 2 CGordon 2017-12-14 19:14:34 UTC 
(In reply to CGordon from comment #1)
> A local flag for the "--fast-float-approx" option (FLOAT_APPROX) would be
> fine.

*--enable-float-approx
Comment 3 Larry the Git Cow gentoo-dev 2019-05-22 01:25:30 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33935a110ddaa4bcac9a61a66392473f436e29ca

commit 33935a110ddaa4bcac9a61a66392473f436e29ca
Author:     Peter Levine <plevine457@gmail.com>
AuthorDate: 2019-05-20 03:25:00 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2019-05-22 01:23:24 +0000

    media-libs/opus: enable building with -ffast-math or -Ofast
    
    Add support for --enable-float-approx configure option which enables
    functions that are safe to use with the -ffast-math C{XX}FLAG.
    
    Package-Manager: Portage-2.3.66, Repoman-2.3.12
    Closes: https://bugs.gentoo.org/621978
    Signed-off-by: Peter Levine <plevine457@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/12060
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 media-libs/opus/opus-1.3.1-r1.ebuild | 42 ++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)