Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 620138 - app-misc/grc-1.11 Regression: Automatically extends shell environment (without notice)
Summary: app-misc/grc-1.11 Regression: Automatically extends shell environment (withou...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-29 14:45 UTC by Torbjörn Lönnemark
Modified: 2017-11-13 20:46 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
grc-1.11-r1.ebuild (grc-1.11-r1.ebuild,1.35 KB, text/plain)
2017-11-11 22:16 UTC, zlg (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torbjörn Lönnemark 2017-05-29 14:45:39 UTC
Unlike previous versions, 1.11 automatically installs grc.bashrc as /etc/profile.d/grc.sh.

If you're upgrading from a previous version, this means that your shell will start prefixing some of your commands with the grc executable *without any warning*.

This can be very alarming (until you figure out what actually happened).

At the very least, the ebuild should inform of such a major change in behaviour. Preferably, though, it should be reverted to the behaviour of the previous version (i.e. installing the file into /usr/share/grc/).
Comment 1 poncho 2017-08-11 09:39:54 UTC
Please let the user manually configure with of those they want to use and don't install the grc.bashrc by default.

The options would be:
grc.bashrc
grc.zsh
grc.fish
Comment 2 Andreas Proteus 2017-08-11 10:31:19 UTC
(In reply to poncho from comment #1)
> Please let the user manually configure with of those they want to use and
> don't install the grc.bashrc by default.

I second this proposal.
Comment 3 zlg (RETIRED) gentoo-dev 2017-11-11 22:16:33 UTC
Created attachment 503658 [details]
grc-1.11-r1.ebuild

I've attached a new version of grc-1.11-r1.ebuild. It installs all shell-specific configuration to /usr/share/grc (as before) and includes instructions for those who were depending on the prior (wrong) behavior.

If this works out for you guys I'll go ahead and push.
Comment 4 poncho 2017-11-12 08:29:55 UTC
Sure, this would work for me since I use a zsh configuration (like oh-my-zsh) to set up grc anyway.
Comment 5 Larry the Git Cow gentoo-dev 2017-11-13 20:46:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=73638c2c82b42bfa0eead47420de1cf6941fd19e

commit 73638c2c82b42bfa0eead47420de1cf6941fd19e
Author:     Daniel Campbell <zlg@gentoo.org>
AuthorDate: 2017-11-13 20:45:27 +0000
Commit:     Daniel Campbell <zlg@gentoo.org>
CommitDate: 2017-11-13 20:45:53 +0000

    app-misc/grc: Install all shell-specific config
    
    This commit fixes a regression in the previous ebuild that was
    installing grc.bashrc into /etc/profile.d unconditionally. The new
    version installs them all to /usr/share/grc and lets the user decide how
    to integrate it with their system.
    
    Thanks to Torbjörn Lönnemark, poncho, Andreas Porteus.
    
    Closes: https://bugs.gentoo.org/620138
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 app-misc/grc/grc-1.11-r1.ebuild | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)