Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 619968 - sys-apps/biosdisk: uses doman on compressed file
Summary: sys-apps/biosdisk: uses doman on compressed file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Schultz
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: doman-compressed
  Show dependency tree
 
Reported: 2017-05-28 09:23 UTC by Michał Górny
Modified: 2018-03-13 19:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
biosdisk-0_p20100620.ebuild (biosdisk-0_p20100620.ebuild,991 bytes, text/plain)
2017-06-18 22:26 UTC, Matthew Schultz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-05-28 09:23:19 UTC
The package uses doman/newman on a compressed file which is invalid per PMS:

     doman biosdisk.8.gz
Comment 1 Matthew Schultz 2017-06-18 22:26:21 UTC
Created attachment 477194 [details]
biosdisk-0_p20100620.ebuild

ebuild now uncompresses man files before calling doman.  I've also updated the SRC_URI since the old one returns a 404 and the repo was moved to github.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-06-23 09:04:04 UTC
Could you please file a pull request for this? Also remember to update the copyright date when you are modifying the file.
Comment 3 Matthew Schultz 2017-06-23 13:10:35 UTC
(In reply to Michał Górny from comment #2)
> Could you please file a pull request for this? Also remember to update the
> copyright date when you are modifying the file.

Sure, where do I file the PR?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-06-23 13:27:57 UTC
(In reply to Matthew Schultz from comment #3)
> (In reply to Michał Górny from comment #2)
> > Could you please file a pull request for this? Also remember to update the
> > copyright date when you are modifying the file.
> 
> Sure, where do I file the PR?

https://github.com/gentoo/gentoo/pulls
Comment 5 Matthew Schultz 2018-01-06 06:46:18 UTC
https://github.com/gentoo/gentoo/pull/6764
Comment 6 Larry the Git Cow gentoo-dev 2018-03-13 19:16:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bab6276dd44ac426473cdc737f217d8a1ad50aa4

commit bab6276dd44ac426473cdc737f217d8a1ad50aa4
Author:     Matthew Schultz <mattsch@gmail.com>
AuthorDate: 2018-01-08 18:07:30 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-03-13 19:16:25 +0000

    sys-apps/biosdisk: Removed old 20100611 version.
    
    Removed old version since the SRC_URI returns a 404 not found due to the repository being moved from dell.com to github. (bug #619968)
    
    Closes: https://bugs.gentoo.org/619968
    Closes: https://github.com/gentoo/gentoo/pull/6764
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 sys-apps/biosdisk/Manifest                       |  1 -
 sys-apps/biosdisk/biosdisk-0_p20100611-r1.ebuild | 45 ------------------------
 2 files changed, 46 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d7c9bc973e172a940251f8b39c9e446a713ad0c

commit 6d7c9bc973e172a940251f8b39c9e446a713ad0c
Author:     Matthew Schultz <mattsch@gmail.com>
AuthorDate: 2018-01-08 18:04:48 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-03-13 19:16:25 +0000

    sys-apps/biosdisk: version bump to 20171116 git commit.
    
    Bumped to most recent git commit by date.  Changed the repo to github since it no longer exists on dell.com. (bug #619968)
    
    Bug: https://bugs.gentoo.org/619968
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 sys-apps/biosdisk/Manifest                    |  1 +
 sys-apps/biosdisk/biosdisk-0_p20171116.ebuild | 43 +++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)}