Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 617924 - mail-client/alpine-2.00-r7: Please make pam optional
Summary: mail-client/alpine-2.00-r7: Please make pam optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Robert G. Siebeck
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2017-05-09 05:33 UTC by Martin Väth
Modified: 2019-11-07 05:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for Makefile.in to avoid linking to pam (2.00-lpam.patch,295 bytes, patch)
2017-05-09 05:33 UTC, Martin Väth
Details | Diff
Patch for the ebuild to provide USE=pam and patch configure.ac (alpine-pam-optional.patch,913 bytes, patch)
2017-05-09 05:33 UTC, Martin Väth
Details | Diff
patch for alpine-2.21.1-r1.ebuild (alpine-2.21.1-r1.patch,643 bytes, patch)
2018-11-16 20:18 UTC, Martin Väth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2017-05-09 05:33:06 UTC
Created attachment 472044 [details, diff]
Patch for Makefile.in to avoid linking to pam

Currently, users of alpine are forced to install pam.
I request to provide a USE=pam which makes pam optional.

This only requires patching a single line in Makefile.in
and to replace a check in configure.ac

The patch for Makefile.in and a possible patch for the ebuild to apply the patch and to fix configure.ac are attached.
Comment 1 Martin Väth 2017-05-09 05:33:50 UTC
Created attachment 472046 [details, diff]
Patch for the ebuild to provide USE=pam and patch configure.ac
Comment 2 Virgil Dupras (RETIRED) gentoo-dev 2018-10-11 14:30:23 UTC
Robert, you alpine's maintainer. Have you reviewed this patch?
Comment 3 Robert G. Siebeck 2018-11-14 18:47:30 UTC
Martin, thanks for the patch. Can you port it to the recent alpine ebuid (version 2.21.1-r1)?
Comment 4 Martin Väth 2018-11-16 20:18:18 UTC
Created attachment 555358 [details, diff]
patch for alpine-2.21.1-r1.ebuild

The only change for newer ebuilds is that the 2.00-lpam.patch is never applied.
Comment 5 Robert G. Siebeck 2018-12-15 14:05:47 UTC
(In reply to Martin Väth from comment #4)
> Created attachment 555358 [details, diff] [details, diff]
> patch for alpine-2.21.1-r1.ebuild
> 
> The only change for newer ebuilds is that the 2.00-lpam.patch is never
> applied.

Thanks! I tested the patch successfully and created a PR.
Comment 6 Larry the Git Cow gentoo-dev 2019-11-07 05:42:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cdc9317f37aedfaf956f7f72ef46f73b97f31170

commit cdc9317f37aedfaf956f7f72ef46f73b97f31170
Author:     Robert Siebeck <gentoo.2019@r123.de>
AuthorDate: 2018-11-17 18:27:32 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-11-07 05:42:29 +0000

    mail-client/alpine: make PAM optional
    
    Closes: https://bugs.gentoo.org/617924
    
    Signed-off-by: Robert Siebeck <gentoo.bugzilla.2012@r123.de>
    Closes: https://github.com/gentoo/gentoo/pull/10645
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 mail-client/alpine/alpine-2.21.1-r2.ebuild         | 95 ++++++++++++++++++++++
 mail-client/alpine/files/alpine-2.21.1-nopam.patch | 27 ++++++
 2 files changed, 122 insertions(+)