Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 617440 - x11-libs/wxGTK-3.0.2.0[-X] should provide wx/evtloopsrc.h
Summary: x11-libs/wxGTK-3.0.2.0[-X] should provide wx/evtloopsrc.h
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Gentoo wxWidgets project
URL: https://trac.wxwidgets.org/ticket/18038
Whiteboard:
Keywords:
Depends on:
Blocks: wxgtk2-removal 605018
  Show dependency tree
 
Reported: 2017-05-04 07:13 UTC by Sylvain CANOINE
Modified: 2018-07-05 15:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvain CANOINE 2017-05-04 07:13:09 UTC
Error encountered when compiling amule-2.3.2-r1 :

/usr/include/wx-3.0/wx/unix/apptbase.h:15:27: fatal error: wx/evtloopsrc.h: No such file or directory

Same problem : https://bugs.gentoo.org/show_bug.cgi?id=605018
The provided patch (thanks Sandino Araico Sanchez) solves the bug : https://bugs.gentoo.org/attachment.cgi?id=459126

Reproducible: Always
Comment 1 kuzetsa CatSwarm (kuza for short) 2017-12-21 22:27:14 UTC
This goes away "for free" with the upcoming version bump:

$ equery belongs evtloopsrc.h
 * Searching for evtloopsrc.h ... 
x11-libs/wxGTK-3.0.3.1 (/usr/include/wx-3.0/wx/evtloopsrc.h)
x11-libs/wxGTK-3.0.3.1 (/usr/include/wx-3.0/wx/gtk/evtloopsrc.h)
x11-libs/wxGTK-3.0.3.1 (/usr/include/wx-3.0/wx/unix/evtloopsrc.h)
x11-libs/wxGTK-3.0.3.1-r300 (/usr/include/wx-3.0-gtk3/wx/gtk/evtloopsrc.h)
x11-libs/wxGTK-3.0.3.1-r300 (/usr/include/wx-3.0-gtk3/wx/evtloopsrc.h)
x11-libs/wxGTK-3.0.3.1-r300 (/usr/include/wx-3.0-gtk3/wx/unix/evtloopsrc.h)
Comment 2 Mart Raudsepp gentoo-dev 2018-01-04 03:20:31 UTC
Actually this problem is probably still present. wx/evtloopsrc.h is part of COND_USE_GUI_1_ALL_GUI_HEADERS, so it probably isn't installed with wxGTK[-X], while it apparently should.
Would be nice to have an upstream bug report on this, or a past one (or commit id) if it's fixed in wxWidgets master.
Comment 3 Mart Raudsepp gentoo-dev 2018-01-04 16:07:27 UTC
I will have a change included in wxGTK-3.0.3 and wxGTK-3.0.3-r300 soon (commits bot will ping once I have it pushed after a final test). Once there, please test if it solves this for amule, as I couldn't test with wxGTK[-X] myself. wx/evtloopsrc.h now gets installed in core only builds as well, so it either is fixed now, or it fails deeper down. Reports based on the patch that was attached here suggest that it might work out fine.
The important thing here is wxGTK[-X], that is, no USE=X on wxGTK. wxGTK[X] was fine before too, for amule[-X] builds.
Comment 4 Larry the Git Cow gentoo-dev 2018-01-04 17:18:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e16e67f0678b264a04e96954a4593ddac3a9a32d

commit e16e67f0678b264a04e96954a4593ddac3a9a32d
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-01-04 03:44:12 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-01-04 17:18:28 +0000

    x11-libs/wxGTK: Apply patchset for lots of 3.0 branch fixes and webkit-gtk:4 port
    
    Includes 105 patches taken from WX_3_0_BRANCH, plus one from master only that we
    need to not litter DT_NEEDED with wxWebView library without --as-needed (it was
    part of squashed wxGTK-3.0.2.0-webview-fixes.patch before). Also includes my patch
    to install wx/evtloopsrc.h in core-only builds.
    Most notably the patchset adds support for webkit2gtk API (as provided by security
    safe net-libs/webkit-gtk:4), and lots of gtk3 port fixes, hopefully making 3.0-gtk3
    SLOT good enough for mass transition without problematic runtime regressions.
    
    The patchset touches lines right above the first Makefile.in changes in the
    collision patch, so that patch needed to be adjusted to not fail on top of the
    patchset. Ideally the collision patch would be revised and moved to the same
    approach as 3.0-gtk3 has with seds - or vice-versa, but at least same approach..
    
    Compiling amule[-X] and veracrypt[-X] against wxGTK[-X] is untested; please test
    and close the relevant bugs (617440 and 605018) if this is fixed now.
    
    Bug: https://bugs.gentoo.org/629122
    Bug: https://bugs.gentoo.org/617440
    Bug: https://bugs.gentoo.org/605018
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 x11-libs/wxGTK/Manifest                          |  1 +
 x11-libs/wxGTK/files/wxGTK-3.0.3-collision.patch | 75 ++++++++++++++++++++++++
 x11-libs/wxGTK/wxGTK-3.0.3-r300.ebuild           |  4 +-
 x11-libs/wxGTK/wxGTK-3.0.3.ebuild                |  4 +-
 4 files changed, 82 insertions(+), 2 deletions(-)}
Comment 5 Mart Raudsepp gentoo-dev 2018-07-05 15:34:32 UTC
With no-one reporting continued failure, I guess I'll consider this fixed then.