Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616364 - sys-fs/dd-rescue-1.99.5 fails to build on ARM due to musl compatibility patch
Summary: sys-fs/dd-rescue-1.99.5 fails to build on ARM due to musl compatibility patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-23 08:14 UTC by Jan Huwald
Modified: 2017-10-30 21:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed sys-fs/dd-rescue/files/dd_rescue-1.99-musl.patch (dd_rescue-1.99-musl.patch,2.34 KB, patch)
2017-04-23 08:14 UTC, Jan Huwald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Huwald 2017-04-23 08:14:22 UTC
Created attachment 470702 [details, diff]
Fixed sys-fs/dd-rescue/files/dd_rescue-1.99-musl.patch

sys-fs/dd-rescue-1.99.5 fails to build on arm with glibc due to missing system header sys/reg.h. The root cause is the Gentoo specific patch sys-fs/dd-rescue/files/dd_rescue-1.99-musl.patch which adds the include directive
#include <sys/reg.h>
to several source files. sys/reg.h is unavailable on ARM (at least with glibc).

Hiding the include directive inside an #ifndef __WORDSIZE fixes the issue for me while still maintaining compatibility with musl. An updated patch is attached.
Comment 1 Larry the Git Cow gentoo-dev 2017-10-30 21:08:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e04bc2e851ac54864c388a674af9d0ce3c83ff66

commit e04bc2e851ac54864c388a674af9d0ce3c83ff66
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2017-10-30 21:07:42 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2017-10-30 21:08:35 +0000

    sys-fs/dd-rescue: Rev bump to fix build issue on ARM caused by MUSL patch
    
    In addition:
    
    - OpenSSL removal updated (crypto_EVP_aes_192_ctr lib check)
    
    - lzo USE flag handling fixed (HAVE_LZO_LZO1X_H caused to build with
      lzo even when USE=-lzo was set but dev-libs/lzo was installed)
    
    - HMAC tests disabled due to https://sourceforge.net/p/ddrescue/tickets/3/
    
    Closes: https://bugs.gentoo.org/616364
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 sys-fs/dd-rescue/dd-rescue-1.99.6-r1.ebuild        |  93 ++++++++++++
 .../files/dd_rescue-1.99-disable-hmac-tests.patch  |  21 +++
 .../dd-rescue/files/dd_rescue-1.99-musl-r1.patch   | 161 +++++++++++++++++++++
 3 files changed, 275 insertions(+)
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2017-10-30 21:09:27 UTC
I merged a different patch. Please re-open if it doesn't work for you. Thanks for the report!