Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616274 - dev-python/reportlab: Test fail without network; test errors are ignored
Summary: dev-python/reportlab: Test fail without network; test errors are ignored
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-22 09:29 UTC by Michał Górny
Modified: 2019-01-27 16:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-22 09:29:05 UTC
The tests for this package attempt to use two remote files, therefore failing without network access. Even worse, the test failure does not cause the ebuild to stop -- I suspect the runAll.py script does not exit with non-zero status on error.


 * python2_7: running distutils-r1_run_phase python_test
.......................................................................................................................................E............................E................................................................................
======================================================================
ERROR: test9 (test_lib_utils.ImporterTestCase)
test open and read of an http: URL
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0/tests/test_lib_utils.py", line 117, in test9
    b = open_and_read('http://www.reportlab.com/rsrc/encryption.gif')
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/lib/utils.py", line 673, in open_and_read
    f = open_for_read(name,mode)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/lib/utils.py", line 669, in open_for_read
    raise IOError('Cannot open resource "%s"' % name)
IOError: Cannot open resource "http://www.reportlab.com/rsrc/encryption.gif"

======================================================================
ERROR: test0 (test_platypus_general.PlatypusTestCase)
Make a platypus document
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0/tests/test_platypus_general.py", line 566, in test0
    run()
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0/tests/test_platypus_general.py", line 559, in run
    doc.build(commentary,examples)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0/tests/test_platypus_general.py", line 546, in build
    self.fillFrame(flowables2)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0/tests/test_platypus_general.py", line 537, in fillFrame
    self.handle_flowable(flowables)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/platypus/doctemplate.py", line 821, in handle_flowable
    if frame.add(f, canv, trySplit=self.allowSplitting):
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/platypus/frames.py", line 167, in _add
    w, h = flowable.wrap(aW, h)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/platypus/flowables.py", line 484, in wrap
    return self.drawWidth, self.drawHeight
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/platypus/flowables.py", line 478, in __getattr__
    self._setup_inner()
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/platypus/flowables.py", line 442, in _setup_inner
    img = self._img
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/platypus/flowables.py", line 472, in __getattr__
    self._img = ImageReader(self._file)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/lib/utils.py", line 807, in __init__
    annotateException('\nfileName=%r identity=%s'%(fileName,self.identity()))
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/lib/utils.py", line 1387, in annotateException
    rl_reraise(t,v,b)
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/lib/utils.py", line 771, in __init__
    self.fp = open_for_read(fileName,'b')
  File "/tmp/portage/dev-python/reportlab-3.3.0-r1/work/reportlab-3.3.0-python2_7/lib/reportlab/lib/utils.py", line 669, in open_for_read
    raise IOError('Cannot open resource "%s"' % name)
IOError: Cannot open resource "http://www.reportlab.com/rsrc/encryption.gif"
fileName='http://www.reportlab.com/rsrc/encryption.gif' identity=[ImageReader@0x7f209af66c90 filename='http://www.reportlab.com/rsrc/encryption.gif']

----------------------------------------------------------------------
Ran 245 tests in 140.629s

FAILED (errors=2)
Comment 1 Virgil Dupras (RETIRED) gentoo-dev 2019-01-27 15:23:59 UTC
The "not returning an error code when tests fail" part has already been fixed upstream. Bump + disabling of network tests incoming.
Comment 2 Larry the Git Cow gentoo-dev 2019-01-27 16:01:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=560a92f6f491c6b3369ce7d7ee4d6d7048ae4d7b

commit 560a92f6f491c6b3369ce7d7ee4d6d7048ae4d7b
Author:     Virgil Dupras <vdupras@gentoo.org>
AuthorDate: 2019-01-27 16:00:35 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2019-01-27 16:01:39 +0000

    dev-python/reportlab: bump to 3.5.13
    
    I removed the sed and eprefixy because they had no effect.
    
    I also disabled the two tests accessing internet through patching.
    
    Closes: https://bugs.gentoo.org/616274
    Signed-off-by: Virgil Dupras <vdupras@gentoo.org>
    Package-Manager: Portage-2.3.51, Repoman-2.3.11

 dev-python/reportlab/Manifest                      |  1 +
 .../reportlab-3.5.13-disable-network-tests.patch   | 23 ++++++++
 dev-python/reportlab/reportlab-3.5.13.ebuild       | 65 ++++++++++++++++++++++
 3 files changed, 89 insertions(+)