Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 615290 - net-p2p/bitcoin-qt: use provided desktop file
Summary: net-p2p/bitcoin-qt: use provided desktop file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Luke-Jr
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-11 17:07 UTC by Andrius Štikonas
Modified: 2018-02-07 00:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius Štikonas 2017-04-11 17:07:16 UTC
Why doesn't ebuild use
bitcoin/bitcoin/blob/master/contrib/debian/bitcoin-qt.desktop
from bitcoin source.

Now desktop file is autogenerated, which is not good for translations. Also it doesn't work on Wayland. Wayland expects desktop file to be properly named which for bitcoin-qt is bitcoin-qt.desktop and window and taskbar icon is taken from desktop file.
Comment 1 Luke-Jr 2017-05-04 18:20:09 UTC
Should now be fixed in the bitcoin overlay (0.14.1-r1).
Comment 2 Larry the Git Cow gentoo-dev 2017-12-31 16:20:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a84ae2045d1d2b5fb39f68731bbe17e2e9c6462

commit 0a84ae2045d1d2b5fb39f68731bbe17e2e9c6462
Author:     Luke Dashjr <luke-jr+git@utopios.org>
AuthorDate: 2017-12-10 15:07:54 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2017-12-31 16:20:22 +0000

    net-p2p/bitcoin-qt: Bump to 0.15.1
    
    Closes: https://bugs.gentoo.org/615290
    Closes: https://bugs.gentoo.org/631890
    Closes: https://bugs.gentoo.org/640674
    Closes: https://github.com/gentoo/gentoo/pull/6272

 net-p2p/bitcoin-qt/Manifest                 |   2 +
 net-p2p/bitcoin-qt/bitcoin-qt-0.15.1.ebuild | 253 ++++++++++++++++++++++++++++
 net-p2p/bitcoin-qt/metadata.xml             |   3 +
 3 files changed, 258 insertions(+)
Comment 3 Andrius Štikonas 2018-02-07 00:33:27 UTC
Hi,

I tested this with 0.15.1. The icon is still not working on Wayland. Looks like bitcoin-qt now sets reverse domain too, so desktop file should be named

org.bitcoin.bitcoin-qt.desktop

Can we change this?
Comment 4 Luke-Jr 2018-02-07 00:50:00 UTC
Sounds like a bug in Wayland, unless you can point to some standard being violated.

Regardless, I don't see what it has to do with this now-fixed bug...

Also, no idea why you'd suggest renaming it to that. It has nothing to do with Bitcoin.org...