Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 614492 - app-vim/perl-support: optional dependencies
Summary: app-vim/perl-support: optional dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-02 07:34 UTC by Ferenc Erki
Modified: 2017-11-09 23:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
perl-support-5.4.ebuild (perl-support-5.4.ebuild,1.20 KB, text/plain)
2017-04-11 01:50 UTC, Ferenc Erki
Details
perl-support-5.4.ebuild (perl-support-5.4.ebuild,1.34 KB, text/plain)
2017-04-11 15:47 UTC, Ferenc Erki
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ferenc Erki 2017-04-02 07:34:04 UTC
app-vim/perl-support can utilize the following modules as stated in its docs:

  Devel::SmallProf     - per-line Perl profiler
  Devel::FastProf      - per-line Perl profiler
  Devel::NYTProf       - per-line Perl profiler
  Devel::ptkdb         - Perl debugger using a Tk GUI
  Perl::Critic         - Critique Perl source code for best-practices
  Perl::Tags           - Generate Ctags style tags for Perl source code
                         (see |perlsupport-perltags|)
  Perl::Tidy           - Parses and beautifies perl source
  Pod::Pdf             - A POD to PDF translator
  YAPE::Regex::Explain - regular expression analyzer

From that list, currently these are specified already as RDEPEND:

    - dev-perl/Perl-Tags
    - dev-perl/Perl-Critic

And the following are also in portage:

    - dev-perl/Devel-SmallProf
    - dev-perl/Devel-NYTProf
    - dev-perl/Perl-Tidy

As far as I can tell, those are only optional dependencies, but it would be
nice to add them in order to provide a more full perl-support experience out
of the box. Some of them can/should even be controlled via local USE
flags in order to let users choose what they actually need.

Alternatively the ebuild can specify none of those dependencies, and just print
a nice post_install message about "install those if you need them".

Maybe this can be done together with the version bump on bug 613928.
Comment 1 Ferenc Erki 2017-04-11 01:50:37 UTC
Created attachment 469666 [details]
perl-support-5.4.ebuild

I'm attaching a proposed ebuild to handle more optional deps.

Changes since 5.3.2:
 - bump version
 - use more optional dependencies
 - document the rest of the optional dependencies

Please review, and let me know if you'd like me to do further modifications.
Comment 2 Patrick Lauer gentoo-dev 2017-04-11 14:05:25 UTC
>>> Downloading 'https://dev.gentoo.org/~radhermit/vim/perl-support-5.4.tar.bz2'
--2017-04-11 16:04:31--  https://dev.gentoo.org/~radhermit/vim/perl-support-5.4.tar.bz2
Resolving dev.gentoo.org... 140.211.166.183, 2001:470:ea4a:1:5054:ff:fec7:86e4
Connecting to dev.gentoo.org|140.211.166.183|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-04-11 16:04:32 ERROR 404: Not Found.

!!! Couldn't download 'perl-support-5.4.tar.bz2'. Aborting.


That looks like a little oversight in the proposed ebuild ...
Comment 3 Ferenc Erki 2017-04-11 15:47:01 UTC
Created attachment 469686 [details]
perl-support-5.4.ebuild

I must have been fooled by an already downloaded distfile :)

I'm attaching an updated ebuild.

Changes since 5.3.2:
 - bump version
 - use more optional dependencies
 - document the rest of the optional dependencies
 - fixed SRC_URI

Please review, and let me know if you'd like me to do further modifications.
Comment 4 Ferenc Erki 2017-05-10 07:02:25 UTC
Can I get a review of this, please? I'm happy to address any further concerns :)
Comment 5 Larry the Git Cow gentoo-dev 2017-11-09 23:14:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b70de5a820f1d9842cad5e70589ded41de7e53e2

commit b70de5a820f1d9842cad5e70589ded41de7e53e2
Author:     Ferenc Erki <erkiferenc@gmail.com>
AuthorDate: 2017-10-29 22:30:48 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2017-11-09 23:13:36 +0000

    app-vim/perl-support: handle optional dependencies.
    
    Closes: https://bugs.gentoo.org/614492
    Closes: https://github.com/gentoo/gentoo/pull/6078
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 app-vim/perl-support/perl-support-5.4.ebuild | 15 +++++++++++++++
 1 file changed, 15 insertions(+)