Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612426 - =media-libs/gstreamer-1.10.4 installs bash completions in wrong place
Summary: =media-libs/gstreamer-1.10.4 installs bash completions in wrong place
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-12 14:02 UTC by Vadim A. Misbakh-Soloviov (mva)
Modified: 2017-09-16 19:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim A. Misbakh-Soloviov (mva) gentoo-dev 2017-03-12 14:02:23 UTC
gstreamer ebuild installs Bash completions at the wrong path:

> $ qlist media-libs/gstreamer | grep bash-comp
> /usr/share/bash-completion/completions/helpers/gst
> /usr/share/bash-completion/completions/helpers/gst-completion-helper-1.0
> /usr/share/bash-completion/completions/completions/gst-inspect-1.0
> /usr/share/bash-completion/completions/completions/gst-launch-1.0

It should install gst-launch-1.0 and gst-inspect-1.0 to
> /usr/share/bash-completion/completions
but not
> /usr/share/bash-completion/completions/completions
and it should install helpers to
/usr/share/bash-completion/helpers
bit not
/usr/share/bash-completion/completions/helpers

As I see in the ebuild, it is `--with-bash-completion-dir="$(get_bashcompdir)"`.
bash-completion-r1 eclass assumes package needs either directory for completions (/usr/share/bash-completion/completions) or for helpers (/usr/share/bash-completion/helpers) and returns that pat respectively with corresponding functions.

So, although `--with-bash-completion-dir="$(get_bashcompdir)"` looks legit, upstream buildsystem use this value with assumption that it is *parent* directory of the "completions" directory, and so, istalls it's own "completions" and "helpers" directory there.


It *can* be fixed by `--with-bash-completion-dir="$(dirname $(get_bashcompdir))"`,
but I guess, it should be reported upstream instead, so upstream should use `--with-bash-completion-dir` as path to "completions" directory, and will add `--with-bash-helpers-dir`, which ebuild of the next version should utilize then too.

I can create a PR with workaround-fix (dirname) if somebody will ACK, but I still think it should be reported upstream...
Comment 1 Larry the Git Cow gentoo-dev 2017-09-16 19:46:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47b6187403f96775a8ed013d80700f59df32ee3e

commit 47b6187403f96775a8ed013d80700f59df32ee3e
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2017-09-13 07:04:30 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2017-09-16 19:43:11 +0000

    media-libs/gstreamer: bump to 1.12.2, fix bash completion
    
    Closes: https://bugs.gentoo.org/612426
    Package-Manager: Portage-2.3.6, Repoman-2.3.2

 media-libs/gstreamer/Manifest                      |   1 +
 .../files/gstreamer-1.12.2-automagic.patch         | 168 +++++++++++++++++++++
 media-libs/gstreamer/gstreamer-1.12.2.ebuild       | 116 ++++++++++++++
 3 files changed, 285 insertions(+)