Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612306 - net-firewall/fwbuilder: uses redundant validate_desktop_entries
Summary: net-firewall/fwbuilder: uses redundant validate_desktop_entries
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Kevin Bauman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-11 12:59 UTC by Michał Górny
Modified: 2017-11-23 20:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-03-11 12:59:29 UTC
net-firewall/fwbuilder/fwbuilder-5.0.1.3592-r1.ebuild:  validate_desktop_entries
net-firewall/fwbuilder/fwbuilder-5.3.6.ebuild:  validate_desktop_entries


However, .desktop file validation is already done by Portage itself, so the call is redundant.
Comment 1 Larry the Git Cow gentoo-dev 2017-09-24 08:34:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5f3b0c0a042d6ed032464bf97fd0eb6643d5628

commit f5f3b0c0a042d6ed032464bf97fd0eb6643d5628
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2017-09-24 08:25:36 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2017-09-24 08:33:46 +0000

    net-firewall/fwbuilder: version bump 5.3.7
    
    Closes: https://bugs.gentoo.org/587158
    Closes: https://bugs.gentoo.org/597608
    Closes: https://bugs.gentoo.org/599466
    Closes: https://bugs.gentoo.org/612306
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 net-firewall/fwbuilder/Manifest               |  1 +
 net-firewall/fwbuilder/fwbuilder-5.3.7.ebuild | 71 +++++++++++++++++++++++++++
 2 files changed, 72 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2017-11-23 20:49:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=92703cae06bcaa87658bcea53bcff7e6db451d7d

commit 92703cae06bcaa87658bcea53bcff7e6db451d7d
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2017-11-22 17:30:52 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2017-11-23 20:49:05 +0000

    net-firewall/fwbuilder: [QA] Remove call to validate_desktop_entries.
    
    This function is deprecated since a long time.
    
    Bug: https://bugs.gentoo.org/612306
    Package-Manager: Portage-2.3.14, Repoman-2.3.6

 net-firewall/fwbuilder/fwbuilder-5.0.1.3592-r1.ebuild | 4 +---
 net-firewall/fwbuilder/fwbuilder-5.3.6.ebuild         | 2 --
 2 files changed, 1 insertion(+), 5 deletions(-)}