Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 610008 - kernel-2.eclass: Incorrect use of python-any-r1
Summary: kernel-2.eclass: Incorrect use of python-any-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on: 610620 610622 610624
Blocks: 803152
  Show dependency tree
 
Reported: 2017-02-19 12:24 UTC by Michał Górny
Modified: 2022-08-07 09:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-02-19 12:24:54 UTC
Your sins include:

1. PYTHON_COMPAT is set in eclass while it belongs in ebuilds. Setting it in eclass breaks our tools, so please don't do that.

2. python-any-r1 is inherited unconditionally while the relevant code is used only with ETYPE==sources, -z K_PREDEBLOBBED and K_DEBLOB_AVAILABLE==1. This creates false positives that you forgot to use the eclass.

3. python-any-r1_pkg_setup is not being called at all. Which means that whatever you set above is not respected anyway.
Comment 1 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2017-02-20 11:56:39 UTC
python_setup is used for K_DEBLOB_AVAILABLE=1

K_DEBLOB_AVAILABLE=1 is used by ck-sources ebuild
Comment 2 Mike Pagano gentoo-dev 2017-02-22 23:41:16 UTC
I need the kernels that support deblob to do the changes in their ebuilds first, then I can fix these.  I'll open up bugs against them and then put them here as blockers.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-12 04:38:01 UTC
ping
Comment 4 Larry the Git Cow gentoo-dev 2022-08-07 09:57:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=20028157ec958fae597441a534b3f045fe2606f3

commit 20028157ec958fae597441a534b3f045fe2606f3
Author:     Alice Ferrazzi <alicef@gentoo.org>
AuthorDate: 2022-07-27 09:16:31 +0000
Commit:     Alice Ferrazzi <alicef@gentoo.org>
CommitDate: 2022-08-07 09:56:29 +0000

    kernel-2.eclass: Force deblob-check to use awk
    
    This patch remove python from the kernel-2.eclass
    by forcing the deblob-check script to use awk instead
    of python.
    
    Closes: https://bugs.gentoo.org/610008
    
    Signed-off-by: Alice Ferrazzi <alicef@gentoo.org>

 eclass/kernel-2.eclass | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)