x11-misc/xscreensaver-5.36 build fails with error below, this is because x11-libs/gdk-pixbuf was built with USE=-X and ebuild did not check it. x86_64-pc-linux-gnu-gcc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -Wmissing-prototypes -Wno-overlength-strings -Wdeclaration-after-statement -std=c89 -U__STRICT_ANSI__ -c -I. -I. -I./../utils -I.. -DSTANDALONE -DHAVE_CONFIG_H -march=native -O2 -pipe -I/usr/include xpm-pixmap.c x86_64-pc-linux-gnu-gcc -pedantic -Wall -Wstrict-prototypes -Wnested-externs -Wmissing-prototypes -Wno-overlength-strings -Wdeclaration-after-statement -std=c89 -U__STRICT_ANSI__ -Wl,-O1 -Wl,--as-needed -L/usr/lib64 -o blitspin blitspin.o screenhack.o fps.o ../utils/resources.o ../utils/visual.o ../utils/usleep.o ../utils/yarandom.o ../utils/utf8wc.o ../utils/xft.o ../utils/grabclient.o xpm-pixmap.o -L/usr/lib64 -lSM -lICE -lXt -lX11 -lXmu -lXext -lm xpm-pixmap.o:xpm-pixmap.c:function xpm_to_pixmap_1: error: undefined reference to 'minixpm_to_ximage' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:588: blitspin] Error 1
This is now fixed. Please close the bug. commit 08a84ae4072eb3a06c6762b29788f3ff6c3d47ef Author: Harri Nieminen <moikkis@gmail.com> Date: Mon Feb 27 18:47:14 2017 +0200 x11-misc/xscreensaver: Depend on x11-libs/gdk-pixbuf[X], fixes #608982 Configure step gives following warning otherwise. Warning: GTK version 2.24.31 was found, but at least one supporting library (gdk-pixbuf-xlib-2.0) was not, so GTK can't be used. Perhaps some of the development packages are not installed? Warning: The GTK libraries do not seem to be available; the `xscreensaver-demo' program requires them. Warning: Use of GDK-Pixbuf was requested, but it was not found. The XPM library is being used instead. Some of the demos will not use images as much as they could. You should consider installing GDK-Pixbuf and re-running configure. (GDK-Pixbuf is recommended over XPM, as it provides support for more image formats.) Gentoo-Bug: https://bugs.gentoo.org/608982 Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: https://github.com/gentoo/gentoo/pull/4091
(In reply to moikkis from comment #1) > This is now fixed. Please close the bug. A revision bump for another branch is no fix.
Fixed in 5.36. Thanks for the report!
(In reply to Jeroen Roovers from comment #2) > (In reply to moikkis from comment #1) > > This is now fixed. Please close the bug. > > A revision bump for another branch is no fix. I wasn't able to reproduce build failure. I managed to get xscreensaver build with x11-libs/gdk-pixbuf[-X]. It did just throw me some warnings. So some users could have xscreensaver with some missing features if gdk-pixbuf[X] wasn't preset at the build time. Thats why I did bump it.
If the result of installed files changes, a revision bump is required. Dropping the revbump is wrong if it built before but with reduced features.
(In reply to Mart Raudsepp from comment #5) > If the result of installed files changes, a revision bump is required. > Dropping the revbump is wrong if it built before but with reduced features. There is a difference indeed: without the dependency being set properly, NOTHING will be installed. This is entirely a compile time fix.
