Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 608974 - mercurial.eclass needs EHG_CONFIG
Summary: mercurial.eclass needs EHG_CONFIG
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Christoph Junghans (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-11 16:27 UTC by Karsten Merkle
Modified: 2018-05-06 13:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten Merkle 2017-02-11 16:27:02 UTC
Hi,

I'm missing a way to give --config to the hg clone commands.

I just got a case at creating media-libs/coin-9999 where .hgsub was given by relativpath, but no subpaths file where given. Hardcoding "--config subpaths.\(.*\)=https://bitbucket.org/Coin3D/coin/\1" into the mercurial.eclass made it work... but that's just a bad hack.

Would be nice to have in my ebuild something like:
EHG_CONFIG="subpaths.\(.*\)=https://bitbucket.org/Coin3D/coin/\1"


with regards
Karsten
Comment 1 Christoph Junghans (RETIRED) gentoo-dev 2017-02-12 17:29:48 UTC
This request seems pretty specific to me. I think it would be easier to override the EHG_CLONE_CMD command in the ebuild.
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2017-02-12 18:07:41 UTC
(In reply to Christoph Junghans from comment #1)
> This request seems pretty specific to me. I think it would be easier to
> override the EHG_CLONE_CMD command in the ebuild.

I guess one would need to modify EHG_PULL_CMD as well.

Does this patch work for you?
<https://github.com/junghans/gentoo/commit/293f7aeff4c23fbfd92623a997d4b7262536706d>
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2017-06-08 23:30:55 UTC
Ping @ Karsten!
Comment 4 Karsten Merkle 2017-06-09 14:10:31 UTC
thanks, but I still don't get --config in my checkout of the working copy, though eclass sourcecode looks with the patch like it may work for clone and update. But code doesn't support --config for checkout of working copy.
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2017-06-09 15:09:43 UTC
(In reply to Karsten Merkle from comment #4)
> thanks, but I still don't get --config in my checkout of the working copy,
> though eclass sourcecode looks with the patch like it may work for clone and
> update. But code doesn't support --config for checkout of working copy.
I see, try this:
https://github.com/junghans/gentoo/commit/8eb39b73043a4c65b671618a7f7cab4c754d6f8a
Comment 6 Fabio Rossi 2018-02-02 17:56:02 UTC
I am facing the same problem with the twin repository https://bitbucket.org/Coin3D/soqt. I confirm that the eclass works for me but the EHG_CONFIG I have used is the following:

EHG_CONFIG="subpaths.\.\./(.*)=https://bitbucket.org/Coin3D/\1"

The only thing is that with this solution the subrepos are not cached anymore in ${DISTDIR}.

Would you mind applying the patch to portage?
Comment 7 Fabio Rossi 2018-02-02 17:57:44 UTC
(In reply to Fabio Rossi from comment #6)

> The only thing is that with this solution the subrepos are not cached
> anymore in ${DISTDIR}.

But I guess this is a problem of hg
Comment 8 Larry the Git Cow gentoo-dev 2018-05-06 13:14:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff7ab2347b054f1f621f13036309be2d4cb020b2

commit ff7ab2347b054f1f621f13036309be2d4cb020b2
Author:     Christoph Junghans <junghans@gentoo.org>
AuthorDate: 2017-02-12 17:50:10 +0000
Commit:     Christoph Junghans <junghans@gentoo.org>
CommitDate: 2018-05-06 13:13:42 +0000

    mercurial.eclass: add EHG_CONFIG (bug #608974)
    
    Closes: https://bugs.gentoo.org/608974

 eclass/mercurial.eclass | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)