Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 608822 - dev-python/ipython - notebook flag ignored
Summary: dev-python/ipython - notebook flag ignored
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal minor
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-10 06:26 UTC by Tyler Slabinski
Modified: 2019-05-01 17:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Slabinski 2017-02-10 06:26:29 UTC
When disabling the notebook flag, dev-python/ipython still brings in dev-python/notebook, www-servers/tornado, and other packages that the notebook flag is suppose to disable.
Comment 1 Marius Brehler 2017-02-13 13:55:30 UTC
Got the 'smp' useflag on? This pulls in ipyparallel which requires notebook.
Comment 2 Tyler Slabinski 2017-02-14 09:42:29 UTC
(In reply to Marius Brehler from comment #1)
> Got the 'smp' useflag on? This pulls in ipyparallel which requires notebook.

Thanks. That does seem to be the issue.

Does it make sense to require the notebook flag to be enabled if the smp flag is enabled?
Comment 3 Marius Brehler 2017-02-16 13:01:51 UTC
Actually ipyparallel only requires notebook if the notebook extension (nbext) should be installed, here the cluster tab a notebook instance. I rather think a useflag might be useful to make this dependency optional in the ipyparallel package.
As we might change this in future ipyparallel ebuilds, I think we shouldn't force ipython's smp useflag pulling in the notebook use flag.
Comment 4 Larry the Git Cow gentoo-dev 2019-05-01 17:08:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=775d2d5c12eca5846ca214765a5f86414d7e5297

commit 775d2d5c12eca5846ca214765a5f86414d7e5297
Author:     Virgil Dupras <vdupras@gentoo.org>
AuthorDate: 2019-05-01 17:08:09 +0000
Commit:     Virgil Dupras <vdupras@gentoo.org>
CommitDate: 2019-05-01 17:08:09 +0000

    dev-python/ipython: make notebook dep actually optional
    
    Closes: https://bugs.gentoo.org/608822
    Signed-off-by: Virgil Dupras <vdupras@gentoo.org>
    Package-Manager: Portage-2.3.62, Repoman-2.3.11

 dev-python/ipython/ipython-7.5.0.ebuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)