Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 607900 - sys-devel/gcc: drop fix_libtool_files.sh
Summary: sys-devel/gcc: drop fix_libtool_files.sh
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-01 09:49 UTC by Martin Mokrejš
Modified: 2017-10-02 22:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Mokrejš 2017-02-01 09:49:51 UTC
Hi,
  I cannot run fix_libtool_files.sh on Gentoo::RAP host because I am not root. Please disable the check for installation where EPREFIX is non-empty.

--- /apps/gentoo/usr/sbin/fix_libtool_files.sh.old      2017-02-01 10:49:17.656062416 +0100
+++ /apps/gentoo/usr/sbin/fix_libtool_files.sh  2017-02-01 10:45:49.987898090 +0100
@@ -39,7 +39,7 @@
 
 . /apps/gentoo/etc/profile || exit 1
 
-if [ ${EUID:-0} -ne 0 ] ; then
+if [ ${EUID:-0} -ne 0   -a   "${EPREFIX}" != '' ] ; then
        echo "${0##*/}: Must be root."
        exit 1
 fi
Comment 1 Benda Xu gentoo-dev 2017-02-03 09:14:25 UTC
Is fix_libtool_files.sh still used anywhere?
Comment 2 Martin Mokrejš 2017-02-03 21:59:20 UTC
At least some einfo or ewarn messages print this out on my screen, and provided I switched couple of times back and forth my compiler using gcc-config seemed the only way to get rid of ABI incompatibility fixes. But I maybe wrong what this really fixed my issues.
Comment 3 SpanKY gentoo-dev 2017-02-15 08:25:23 UTC
toolchain.eclass still refers to it and will run it in some cases.  we could probably look at dropping it in newer versions and see if anyone notices or complains.

the biggest reason for its existence no longer exists -- libstdc++.la is dead.
Comment 4 Larry the Git Cow gentoo-dev 2017-10-02 22:23:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ee9d48fff5698bc024a307f01383546025d8f6b

commit 3ee9d48fff5698bc024a307f01383546025d8f6b
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2017-10-02 22:22:55 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2017-10-02 22:23:10 +0000

    sys-devel/gcc: fix_libtool_files.sh: do not require to be root on prefix, bug 607900
    
    Closes: https://bugs.gentoo.org/607900
    Package-Manager: Portage-2.3.10, Repoman-2.3.3

 sys-devel/gcc/files/fix_libtool_files.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)