Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 605930 - www-client/w3m - missing gdk-pixbuf[X?] dependency
Summary: www-client/w3m - missing gdk-pixbuf[X?] dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: CJK Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 534330
  Show dependency tree
 
Reported: 2017-01-16 18:13 UTC by Mart Raudsepp
Modified: 2018-04-03 13:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (0001-www-client-w3m-Fix-gdk-pixbuf-USE-dependency.patch,1.45 KB, patch)
2017-01-16 18:17 UTC, Mart Raudsepp
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2017-01-16 18:13:12 UTC
w3m seems to use the gdk_pixbuf_xlib_* APIs, which are provided by a separate extra library by gdk-pixbuf - currently behind USE=X, but we are considering renaming it to not have it enabled for all by default on desktop profiles.

Please USE depend on this correctly with x11-libs/gdk-pixbuf[X?] instead of just x11-libs/gdk-pixbuf. [X?] because the gdk_pixbuf_xlib stuff is used only in the x11 framebuffer /usr/libexec/w3m/w3mimgdisplay thing, not for the non-x11 stuff, where only generic gdk-pixbuf API is used.

Additionally I'm not sure why it's behind a USE=gtk, as gtk+ itself isn't pulled in and gdk-pixbuf is just a glib based in-memory image library with no dependencies on gtk+; I guess nothing more suitable was found to differentiate that from imlib nicely. If you keep USE=gtk, please at least provide a local USE flag description that tells it's just gdk-pixbuf or something, not "Add support for x11-libs/gtk+"

Also the comment before depends in ebuild seems outdated now:
# We cannot build w3m with gtk+2 w/o X because gtk+2 ebuild doesn't
# allow us to build w/o X, so we have to give up framebuffer w3mimg....

gdk-pixbuf has been split up long ago and after that the depends seem to have been adjusted to the without X USE flag stuff as the comment desired already, except missing the fact that gdk-pixbuf[X] is needed if USE=X.

We might rename the flag later on to have that library not built by default on desktop profiles, but then we can catch these by the USE depends and rename it in the consumers.
Comment 1 Mart Raudsepp gentoo-dev 2017-01-16 18:17:36 UTC
Created attachment 460356 [details, diff]
Proposed patch

Patch to fix this. I noticed imlib also enables unconditional USE=X dependency on imlib - maybe that should be [X?] as well, but I did not investigate. For the gdk-pixbuf case, I actually tested by seeing w3m preserved-libs after re-installing gdk-pixbuf without USE=X, and then seeing that w3m builds fine afterwards with USE=-X on w3m.
Comment 2 Mart Raudsepp gentoo-dev 2017-01-16 18:18:30 UTC
The patch doesn't address the USE flag concern or local description for it, need maintainer decision there which way to go.
Comment 3 Mart Raudsepp gentoo-dev 2018-02-16 04:53:16 UTC
ping
Comment 4 Larry the Git Cow gentoo-dev 2018-04-03 13:32:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97d6e3e6839898829e8cce211b97a7fa77f5d06e

commit 97d6e3e6839898829e8cce211b97a7fa77f5d06e
Author:     Akinori Hattori <hattya@gentoo.org>
AuthorDate: 2018-04-03 13:23:54 +0000
Commit:     Akinori Hattori <hattya@gentoo.org>
CommitDate: 2018-04-03 13:31:36 +0000

    www-client/w3m: fix dependency for w3m-img
    
    Closes: https://bugs.gentoo.org/605930
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 www-client/w3m/files/w3m-img-fb.patch | 10 ++++++++++
 www-client/w3m/metadata.xml           |  1 +
 www-client/w3m/w3m-0.5.3-r9.ebuild    | 32 ++++++++++++++++++--------------
 3 files changed, 29 insertions(+), 14 deletions(-)