Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 605914 - media-plugins/kodi-pvr-hts: version bump and slotting
Summary: media-plugins/kodi-pvr-hts: version bump and slotting
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Miroslav Šulc
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-16 16:13 UTC by gerion
Modified: 2018-12-03 19:07 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kodi-pvr-hts-4.0.2.ebuild (kodi-pvr-hts-4.0.2.ebuild,651 bytes, text/plain)
2017-02-02 22:04 UTC, Andreas Grosse
Details
build.log (build.log,4.22 KB, text/x-log)
2017-02-03 23:47 UTC, Andreas Grosse
Details
emerge --info '=media-plugins/kodi-pvr-hts-4.0.2::andig' (emerge-info,6.98 KB, text/plain)
2017-02-03 23:49 UTC, Andreas Grosse
Details
environment (environment,118.61 KB, text/plain)
2017-02-03 23:49 UTC, Andreas Grosse
Details
media-plugins/kodi-pvr-hts-4.0.7.ebuild (kodi-pvr-hts-4.0.7.ebuild,651 bytes, text/plain)
2017-04-11 10:20 UTC, Xavier Miller (RETIRED)
Details
kodi pvr hts 4.4.2 (kodi-pvr-hts-4.4.2.ebuild,669 bytes, text/plain)
2018-11-22 14:07 UTC, DaggyStyle
Details

Note You need to log in before you can comment on or make changes to this bug.
Description gerion 2017-01-16 16:13:11 UTC
The addon is kodi-17 compatible since January 2016 and kodi-18 compatible since December 2016. It seems the major version number is changed with every Kodi release. Moreover several versions are maintained simultaneously, so maybe slotting would be meaningful.

Source:
https://github.com/kodi-pvr/pvr.hts/blob/master/pvr.hts/changelog.txt
https://github.com/kodi-pvr/pvr.hts/releases/
Comment 1 Andreas Grosse 2017-02-02 22:04:23 UTC
Created attachment 462294 [details]
kodi-pvr-hts-4.0.2.ebuild

Tested the attached ebuild for media-plugins/kodi-pvr-hts-4.0.2 with media-tv/kodi-17.0 and it worked with media-tv/tvheadend-4.0.9. Obvuiously, it is not yet slotted. It is derived from the other updated plugins (media-plugins/kodi-pvr-*).
Comment 2 gerion 2017-02-03 00:06:11 UTC
Thank you. The [changelog](https://github.com/kodi-pvr/pvr.hts/blob/master/pvr.hts/changelog.txt) mentioned, that the 4.0.2 version is for kodi-18 and 3.4.13 for kodi-17. Does 4.0.2 work with kodi-16 as well? If guess, slotting would be meaningless then.
Comment 3 Andreas Grosse 2017-02-03 14:32:38 UTC
The ebuild I posted compiles with Kodi 16.1 and does not crash when I enable the addon. Unfortunately, I am currently not with my Tvheadend, so I can not check if it does really work.
The way I understand the entry "Initial Kodi v18 version" is, that it is the first version that /can/ be compiled for v18. I have verified 4.0.2 working with Kodi 17 and at least not crashing with 16.1. I can test it with Kodi 16.1 the next week.
Comment 4 Andreas Grosse 2017-02-03 23:46:23 UTC
I'm not quite sure what I did yesterday but somehow I managed not to realize that I installed media-plugins/kodi-pvr-hts-16_p20160419 together with Kodi 16.1. kodi-pvr-hts-4.0.2 does not build with Kodi 16.1. Sorry for the misinformation. Maybe slotting is an option here?
Comment 5 Andreas Grosse 2017-02-03 23:47:15 UTC
Created attachment 462388 [details]
build.log
Comment 6 Andreas Grosse 2017-02-03 23:49:25 UTC
Created attachment 462390 [details]
emerge --info '=media-plugins/kodi-pvr-hts-4.0.2::andig'
Comment 7 Andreas Grosse 2017-02-03 23:49:52 UTC
Created attachment 462392 [details]
environment
Comment 8 Miroslav Šulc gentoo-dev 2017-02-04 12:00:56 UTC
what is the point of slotting kodi plugins when kodi itself is not slotted?
Comment 9 gerion 2017-02-04 13:54:40 UTC
With slotting I meant not the ability to install parallel versions, but different slots for different kodi versions.

This would simplify the work for the user. If the user uses a stable kodi (i.e. 16), then he can accept the keyword for "kodi-pvr-hts:kodi-16", if he uses kodi-17 already (or later this year, the betas of kodi-18) he can keyword "kodi-pvr-hts:kodi-17 and still receive updates.

The point for slotting is, that the maintainer of kodi-pvr-hts releases not one linear chain of releases, but point-releases for different major versions.
Comment 10 Miroslav Šulc gentoo-dev 2017-02-04 14:54:07 UTC
idk, i never noticed such a usage. maybe have a look at x11-base/xorg-drivers ebuilds, that might be more proper way of doing this thing. if there would be ebuild called kodi-plugins-${PV} with use flag for each plugin then by installing this ebuild with appropriate plugins selected (by use flags) and with a specific version of kodi-plugins specified, it would require kodi of the same version and kodi plugins with compatible versions (that is older versions of plugins would be blocked for newer versions of kodi as they do not compile against newer kodi etc).
Comment 11 gerion 2017-02-08 15:12:43 UTC
A kodi-plugins-... ebuild would be a valid solution, too. Especially since a lot of other kodi ebuild are added to the tree.

The slot based approach is kind of similar to the whole KDE based ebuilds (check for example media-sound/kid3), that are often not installable in parallel, but indicate with the 4 or 5 slot the affiliation to KDE 4 or 5.
Comment 12 Miroslav Šulc gentoo-dev 2017-02-08 15:17:59 UTC
idk if with kodi plugins it is that strict. i suppose that a kodi plugin might be compatible with version of kodi 16 and 17 (or some versions in the future) at the same time but i might be wrong. and if such a plugin would match two kodi "slots", it would be a problem. this info would come handy.
Comment 13 Xavier Miller (RETIRED) gentoo-dev 2017-04-10 08:38:45 UTC
(In reply to Andreas Grosse from comment #5)
> Created attachment 462388 [details]
> build.log

Hi!

I have the same error. Do I need to switch first to kodi 18?
Comment 14 Xavier Miller (RETIRED) gentoo-dev 2017-04-11 06:59:31 UTC
attachment 462294 [details] works really fine with Kodi 17.1 (I only had to mask kodi-pvr-hts-16* due to the change of the numbering scheme)
Comment 15 Xavier Miller (RETIRED) gentoo-dev 2017-04-11 10:19:27 UTC
media-plugins/kodi-pvr-hts-4.0.7 works fine (bumping attachment 462294 [details] is fine)
Comment 16 Xavier Miller (RETIRED) gentoo-dev 2017-04-11 10:20:26 UTC
Created attachment 469682 [details]
media-plugins/kodi-pvr-hts-4.0.7.ebuild
Comment 17 DaggyStyle 2018-11-22 14:07:15 UTC
Created attachment 555924 [details]
kodi pvr hts 4.4.2

incase someone is intrested, version bump to latest, works with kodi Leia
Comment 18 Craig Andrews gentoo-dev 2018-12-03 18:01:49 UTC
fordfrog,

Would you mind making me co-maintainer of this package?
Comment 19 Miroslav Šulc gentoo-dev 2018-12-03 18:59:16 UTC
(In reply to Craig Andrews from comment #18)
> fordfrog,
> 
> Would you mind making me co-maintainer of this package?

i'd be glad! :-) i'm short of time :-|
Comment 20 Larry the Git Cow gentoo-dev 2018-12-03 19:07:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=139c39312dfecea061893c95276db2d73a17e15f

commit 139c39312dfecea061893c95276db2d73a17e15f
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2018-12-03 19:05:45 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2018-12-03 19:05:45 +0000

    media-plugins/kodi-pvr-hts: 4.4.2 version bump
    
    Closes: https://bugs.gentoo.org/605914
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 media-plugins/kodi-pvr-hts/Manifest                |  1 +
 .../kodi-pvr-hts/kodi-pvr-hts-4.4.2.ebuild         | 35 ++++++++++++++++++++++
 .../kodi-pvr-hts/kodi-pvr-hts-9999.ebuild          |  8 ++---
 media-plugins/kodi-pvr-hts/metadata.xml            |  4 +++
 4 files changed, 44 insertions(+), 4 deletions(-)