Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 605882 - repoman should warn when virtual/ffmpeg is pulled as dependency
Summary: repoman should warn when virtual/ffmpeg is pulled as dependency
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2017-01-16 12:30 UTC by Pacho Ramos
Modified: 2020-09-26 16:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2017-01-16 12:30:27 UTC
Per:
https://www.gentoo.org/support/news-items/2015-02-01-use-libav.html

it seems we should try to move to the new style of depending on ffmpeg and libav. Sadly I took a look to the deptree and there are lots of packages still using the virtual, and some even recently added ebuilds :/

Maybe it would be better if we could at least get a warning to let maintainers know that they should move to the new way of depending on ffmpeg providers

Thanks a lot
Comment 1 Coacher 2017-01-16 12:46:29 UTC
(In reply to Pacho Ramos from comment #0)
Why? virtual/ffmpeg is for ffmpeg/avconv executable, when no linking happens. Such cases exist.

From virtual/ffmpeg ebuild:
# Please note that this virtual is only suited for packages that call
# ffmpeg/avconv or one of the remaining executables. If your package
# links to one of the libraries, you need to use the following
# dependency instead (adding IUSE=libav):
#	libav? ( media-video/libav:0= )
#	!libav? ( media-video/ffmpeg:0= )
Comment 2 Mike Gilbert gentoo-dev 2017-01-16 17:26:16 UTC
Packages with virtual/ffmpeg in RDEPEND only are probably fine.

Packages that have virtual/ffmpeg in DEPEND are suspect: linking against ffmpeg libs is wrong, but calling the binaries is ok.
Comment 3 Jesús P Rey (Chuso) 2020-09-26 12:20:47 UTC
I would say that comment in virtual/ffmpeg is also outdated given that media-video/libav and avconv are abandoned upstream and gone from Portage half year ago.

Also, shouldn't this discussion happen in #744787 instead?
Comment 4 Jesús P Rey (Chuso) 2020-09-26 12:23:32 UTC
Sorry, I just noticed I was replying to old comments written when what I said was still not true.
I though these were new comments to #744784.

Both tickets are related though.
Comment 5 Larry the Git Cow gentoo-dev 2020-09-26 16:00:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2faf7d23d98512885ca32bb0fd81c63fb8220e24

commit 2faf7d23d98512885ca32bb0fd81c63fb8220e24
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-09-26 12:52:40 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-09-26 15:59:38 +0000

    profiles: deprecate virtual/ffmpeg in favour of only provider
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/744787
    Closes: https://bugs.gentoo.org/605882
    Closes: https://github.com/gentoo/gentoo/pull/17678
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 profiles/package.deprecated | 5 +++++
 1 file changed, 5 insertions(+)