Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604990 - arch/amd64/use.mask: update entries for old "PHP" flags
Summary: arch/amd64/use.mask: update entries for old "PHP" flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-01-07 20:53 UTC by Michael Orlitzky
Modified: 2018-01-13 18:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-profiles-consolidate-Oracle-unmask-entries-in-arch-a.patch (0001-profiles-consolidate-Oracle-unmask-entries-in-arch-a.patch,1.72 KB, patch)
2018-01-07 22:13 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2017-01-07 20:53:24 UTC
In arch/x86/use.mask, we have

  # Diego Pettenò <flameeyes@gentoo.org> (4 Jan 2007)
  # Unmask the flags for PHP that are available only on x86/amd64
  -oci8
  -oracle7
  -db2

I don't believe that "oracle7" or "db2" are used at all any more. The "oci8" flag is not used by PHP, so that entry should probably be moved alongside

  # 2007/08/19 - Christoph Mende <angelos@gentoo.org>
  # Unmask support for dev-db/oracle-instantclient-basic
  -oci8-instant-client
  -oracle

to avoid confusion in the future.
Comment 1 Michael Orlitzky gentoo-dev 2017-01-07 20:53:54 UTC
(In reply to Michael Orlitzky from comment #0)
> In arch/x86/use.mask, we have
>

Pretend that says amd64.
Comment 2 Michael Orlitzky gentoo-dev 2018-01-07 22:04:05 UTC
oracle7 and db2 were taken care of by mgorny in 267311c, so that just leaves the erroneous comment about oci8.
Comment 3 Michael Orlitzky gentoo-dev 2018-01-07 22:13:45 UTC
Created attachment 513722 [details, diff]
0001-profiles-consolidate-Oracle-unmask-entries-in-arch-a.patch
Comment 4 Michael Orlitzky gentoo-dev 2018-01-07 22:14:46 UTC
The attached patch consolidates the existing entries, and shouldn't have any visible side-effects.
Comment 5 Michael Orlitzky gentoo-dev 2018-01-10 13:32:47 UTC
I asked on IRC if anyone objects and got no response... since this is functionally a no-op, I'll push it myself after a while.
Comment 6 Larry the Git Cow gentoo-dev 2018-01-13 18:45:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a9cebc414bae9ae0ba0ff4963fb1fdf5c4f1d2e

commit 1a9cebc414bae9ae0ba0ff4963fb1fdf5c4f1d2e
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2018-01-07 22:08:36 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2018-01-13 18:44:04 +0000

    profiles: consolidate Oracle unmask entries in arch/amd64/use.mask.
    
    There were two separate blocks in arch/amd64/use.mask unmasking flags
    pertaining to the Oracle database stuff. One of them had an erroneous
    (outdated) comment. This commit combines them both into one block at
    the top of the file, and drops the obsolete comment about PHP.
    
    Closes: https://bugs.gentoo.org/604990

 profiles/arch/amd64/use.mask | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)