Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604812 - sys-boot/unetbootin-625 compiles without -DNOSTATIC, can't find syslinux
Summary: sys-boot/unetbootin-625 compiles without -DNOSTATIC, can't find syslinux
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-01-06 05:38 UTC by Carl Michal
Modified: 2018-12-21 15:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge.info (info.txt,6.02 KB, text/plain)
2017-01-06 05:38 UTC, Carl Michal
Details
unetbootin-661.ebuild (unetbootin-661.ebuild,2.13 KB, text/plain)
2018-08-23 23:40 UTC, Samuel Bauer
Details
unetbootin-661.ebuild.patch (unetbootin-661.ebuild.patch,535 bytes, patch)
2018-12-20 22:04 UTC, Samuel Bauer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Michal 2017-01-06 05:38:07 UTC
Created attachment 458876 [details]
emerge.info

unetbootin-625 doesn't make usb sticks that are (bios) bootable for me any longer. 608 worked.

I went digging through the source, and the problem appears to be that in 625 now when portage builds it, -DSTATIC is no longer included in the CFLAGS. It should be, per the instructions here:
https://sourceforge.net/p/unetbootin/wiki/compile/
)

I rebuilt 608 from its ebuild, and DSTATIC does get included there.

The consequence of not including DSTATIC is that unetbootin tries to run some internally packaged version of syslinux and fails silently, so no bootloader is installed on the usb stick.

This issue doesn't matter if you're booting UEFI, but booting the usb stick on a bios system fails.

I'm afraid I'm not ebuild-literate enough to see what the difference in the ebuilds is that causes the difference.

As I build 608, the compile commands look like:
x86_64-pc-linux-gnu-g++ -c -O2 -pipe -march=native -fomit-frame-pointer -Wall -W -D_REENTRANT -DNOSTATIC -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4 -I. -I. -I. -o unetbootin.o unetbootin.cpp


but for 625:
x86_64-pc-linux-gnu-g++ -c -O2 -pipe -march=native -fomit-frame-pointer -Wall -W -D_REENTRANT -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4 -I. -I. -I. -o unetbootin.o unetbootin.cpp


emerge --info attached.
Comment 1 Samuel Bauer 2018-08-23 23:40:32 UTC
Created attachment 544740 [details]
unetbootin-661.ebuild

Yesterday, I tried to make a freedos usb stick though unetbootin-661: failure, did with the gentoo wiki approach.
This bug let me find a fix for the current ebuild:

inherit: add flag-o-matic
src_prepare: add;
        append-cflags -DNOSTATIC
        append-cxxflags -DNOSTATIC

Unetbootin qt5 flavour can create bootable sticks.
Comment 2 Carl Michal 2018-12-20 21:10:25 UTC
I just applied Samuel's suggested changes to the ebuild, and it fixes it for me.

Any chance this could be applied?
Comment 3 Samuel Bauer 2018-12-20 22:04:49 UTC
Created attachment 558236 [details, diff]
unetbootin-661.ebuild.patch

If the patch has to be applied, i'll better send a diff than my local version of the ebuild ...

Maybe when qt5 patch is merged upstream and/or 662 is released, it'll push some interest on updating the ebuild.
Comment 4 Larry the Git Cow gentoo-dev 2018-12-21 15:45:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c26355a62f1fb2109259931b8958358de4ed21c

commit 7c26355a62f1fb2109259931b8958358de4ed21c
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2018-12-21 15:45:13 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2018-12-21 15:45:39 +0000

    sys-boot/unetbootin: Fix finding syslinux
    
    Patch by Samuel Bauer
    Fixes: https://bugs.gentoo.org/604812
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 sys-boot/unetbootin/unetbootin-661-r1.ebuild | 101 +++++++++++++++++++++++++++
 1 file changed, 101 insertions(+)