Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 602732 - net-p2p/syncthing-0.14.14 version bump
Summary: net-p2p/syncthing-0.14.14 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Louis Sautier (sbraz)
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 05:40 UTC by Alex
Modified: 2016-12-17 22:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2016-12-15 05:40:53 UTC
I updated ebuild for 0.14.14 version, as some of the old build-related logic isn't needed anymore.

Attached is a patch over syncthing-0.14.13.ebuild.

Thank you in advance.

Reproducible: Always

Steps to Reproduce:
1. unmask syncthing
2. emerge syncthing
3.
Actual Results:  
have old version

Expected Results:  
want new version

Patch file:


--- syncthing-0.14.13.ebuild	2016-12-04 02:50:58.000000000 +0200
+++ syncthing-0.14.14.ebuild	2016-12-15 07:32:51.656080749 +0200
@@ -46,10 +46,7 @@
 src_compile() {
 	export GOPATH="${S}:$(get_golibdir_gopath)"
 	cd src/${EGO_PN} || die
-	# If we pass "build" to build.go, it builds only syncthing itself, and
-	# places the binary in the root folder. If we do not pass "build", all the
-	# tools are built, and all binaries are placed in folder ./bin.
-	go run build.go -version "v${PV}" -no-upgrade $(usex tools "" "build") \
+	go run build.go -version "v${PV}" -no-upgrade install $(usex tools "all" "") \
 		|| die "build failed"
 }
 
@@ -63,15 +60,13 @@
 	doman man/*.[157]
 	einstalldocs
 
+	dobin bin/syncthing
 	if use tools ; then
-		dobin bin/syncthing
 		exeinto /usr/libexec/syncthing
 		local exe
 		for exe in bin/* ; do
 			[[ "${exe}" == "bin/syncthing" ]] || doexe "${exe}"
 		done
-	else
-		dobin syncthing
 	fi
 	popd >& /dev/null || die
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2016-12-15 08:53:53 UTC
Already available in a pull request.
Comment 2 Louis Sautier (sbraz) gentoo-dev 2016-12-15 11:31:06 UTC
I didn't notice the change, I'll look into it.
Comment 3 Alex 2016-12-15 11:35:32 UTC
Cool, never saw that people were that active with PR's on github.

Don't forget to take a quick look at build.go and my changes too.
It failed on `dobin syncthing` for me.

I played around with it and didn't like it, so I doubt I will use it.

Bye.
Comment 4 Patrice Clement (RETIRED) gentoo-dev 2016-12-17 22:02:47 UTC
commit cca5f1dd2d75f4cd6133f46e0c7f59d70204d55d (HEAD)
Author:     Louis Sautier <sautier.louis@gmail.com>
AuthorDate: Wed Dec 14 17:14:20 2016 +0100
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Sat Dec 17 23:02:12 2016 +0100

net-p2p/syncthing: version bump to 0.14.14.

Go 1.7 is no longer required, the build process has been simplified too.

Gentoo-Bug: https://bugs.gentoo.org/602732
Package-Manager: portage-2.3.3
Closes: https://github.com/gentoo/gentoo/pull/3116

Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

net-p2p/syncthing/Manifest                 |   1 +
net-p2p/syncthing/syncthing-0.14.14.ebuild | 115 +++++++++++++++++++++++++++++
2 files changed, 116 insertions(+)
create mode 100644 net-p2p/syncthing/syncthing-0.14.14.ebuild

PR merged, thanks!