Created attachment 456050 [details] Ebuild for autorandr 1.0 I'd like to request adding autorandr [1] to the tree. I volunteer to maintain this package if someone is willing to act as proxy maintainer. I've the ebuild for autorandr-1.0 attached. I also currently maintain a set of x11-misc/autorandr ebuilds in my overlay at https://gitlab.com/Flow/flow-s-ebuilds/ 1: https://github.com/phillipberndt/autorandr
CC'ing monsieurp since he agreed to proxy maintain this.
Created attachment 462906 [details] ebuild with the suggested improvements Hi, I'd like to make some remarks and suggest improvements for the ebuild: - The license should be 'GPL-3+' as oppposed to 'GPL-3' - Using USE flags to pin down dependencies like that is poor in taste. The only difference between USE="systemd" and USE="-systemd", for example, is the installed files and no change in the code. For this reason, let's remove all the USE flags that don't change the behavior of the python code. Likewise, this removes all the runtime dependencies as well. - When multiple python versions are supported, it's better to inherit the distutils-r1 eclass and specify the python implementations in PYTHON_COMPAT - emake doesn't require '|| die' - newbashcomp can be handled as part of emake by passing BASH_COMPLETION_DIR to it - SYSTEMD_UNIT_DIR (inherit systemd) and UDEV_RULES_DIR (inherit udev) should be passed to emake as well - Rather than forcing users' udev to reload, consider printing a message and asking users to do it whenever they wish to do so - I've also added the "autostart_config" target and was wondering why it was excluded originally Let me know what you think about the suggested changes and whether you are still interested in maintaining this package. Thanks,
Created attachment 472054 [details] autorandr-1.0-r20170416.ebuild Update autorandr ebuild with feedback from Göktürk Yüksek. Also in overlay at: https://gitlab.com/Flow/flow-s-ebuilds/tree/master/x11-misc/autorandr > The license should be 'GPL-3+' as oppposed to 'GPL-3' Done > Using USE flags to pin down dependencies like that is poor in taste. The only difference between USE="systemd" and USE="-systemd", for example, is the installed files and no change in the code. For this reason, let's remove all the USE flags that don't change the behavior of the python code. Likewise, this removes all the runtime dependencies as well. I know that this is controversial in gentoo. I'm in the pro systemd/bash-completion use flag camp. But that should not be a blocker for tree inclusion. :) > When multiple python versions are supported, it's better to inherit the distutils-r1 eclass and specify the python implementations in PYTHON_COMPAT Don't you mean the 'python-r1' eclass? Which values should I use in PYTHON_COMPAT? > emake doesn't require '|| die' Done > newbashcomp can be handled as part of emake by passing BASH_COMPLETION_DIR to it Done > SYSTEMD_UNIT_DIR (inherit systemd) and UDEV_RULES_DIR (inherit udev) should be passed to emake as well Done > Rather than forcing users' udev to reload, consider printing a message and asking users to do it whenever they wish to do so I'm not sure if this behavior is better: Users are likely to forget the reload. I guess that is why the udev_reload functions exists in the udev eclass in the first place. > I've also added the "autostart_config" target and was wondering why it was excluded originally Done
@Florian Schmaus: I'm sorry that this bug has never received a reply. I am not a member of proxy-maint anymore but they might have been under the impression that I will follow through with the review. If you are still interested, please contact them again.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=18018454bd6a64cac7aeee5d959734796a6596d5 commit 18018454bd6a64cac7aeee5d959734796a6596d5 Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2021-06-28 09:13:33 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2021-06-28 09:29:10 +0000 x11-misc/autorandr: initial import Closes: https://bugs.gentoo.org/602516 Signed-off-by: Florian Schmaus <flow@gentoo.org> x11-misc/autorandr/Manifest | 1 + x11-misc/autorandr/autorandr-1.11.ebuild | 66 ++++++++++++++++++++++++++++++++ x11-misc/autorandr/autorandr-9999.ebuild | 66 ++++++++++++++++++++++++++++++++ x11-misc/autorandr/metadata.xml | 11 ++++++ 4 files changed, 144 insertions(+)
