Created attachment 455918 [details, diff] Add support for xz compression Please consider the attached patches for inclusion. They build on each other, so if one is omitted, some rework for the later ones may be required. They are against version 1.2.1-r13. #1 Adds support for xz compression. I've been using this for years.
Created attachment 455920 [details, diff] Add support for lzip compressoin
Created attachment 455922 [details, diff] Move find option to avoid warning #3 Move mountpoint_flag up to avoid this warning: find: warning: you have specified the -xdev option after a non-option argument - regex, but options are not positional (-xdev affects tests specified before it as well as those specified after it). Please specify options before other arguments.
Created attachment 455924 [details, diff] Fix indentation #4 This patch simply fixes some indentation.
Created attachment 455926 [details, diff] Avoid code duplication #5 This is a rather cosmetic patch that avoids some code duplication in file_list_cmd(). It may also make this section slightly less readable. I don't feel strongly about if the maintainer decides it's not worth incuding.
Created attachment 455928 [details, diff] Fix bugs in split_list function #6 Rewrite split_list(). This is the big one here and worthy of discussion. I found that subtree pruning totally doesn't work as advertised in flexbackup.conf when there are path names with spaces in them. The current function gets the quoting all wrong for find's -regex option. The replacement function splits the list into a temporary array and parses it character for character where the old version simply splits on single/double quotes if they exist. I ran some tests and found that even the "as long as all elements are quoted" condition did not work for me. Now, list elements are reassembled character by character and pushed into @array when whitespace is detected unless the $q flag indicates that the current whitespace is inside a quoted string, in which case reassembly continues. The beauty of the new implementation is that it fully preserves whitespace inside quoted strings as it doesn't just generally split on whitespace; that means even unlikely names with more than one space or other whitespace are being preserved correctly, such as "a b", "a<tab>b" etc.
I would rather not add these patches because it would mean that the gentoo version would become its own upstream. I would like to limit the patches to those that are absolutely needed to keep flexbackup working. Perhaps you can discuss with the current upstream to become (co-)maintainer?
Is there an active upstream at all? The current release is from 2003.
(In reply to isdtor from comment #7) > Is there an active upstream at all? The current release is from 2003. As far as I'm aware there is no active upstream, but you could contact the original author and/or create a new fork for it.
I executed SourceForge's process to gain write access to an abandoned project and have now become upstream. My first goal is to port in the Gentoo patches, many of which I developed, but I'll take a look at these features as well.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5539aa8161e12a6cb6386545391295a53ac19099 commit 5539aa8161e12a6cb6386545391295a53ac19099 Author: David Seifert <soap@gentoo.org> AuthorDate: 2023-10-08 12:21:56 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2023-10-08 12:21:56 +0000 package.mask: Last rite app-backup/flexbackup Bug: https://bugs.gentoo.org/602382 Signed-off-by: David Seifert <soap@gentoo.org> profiles/package.mask | 6 ++++++ 1 file changed, 6 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6698f2a3d5b1414a28a496dd7479447fb3cce2ec commit 6698f2a3d5b1414a28a496dd7479447fb3cce2ec Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2023-11-08 12:42:52 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2023-11-08 12:42:59 +0000 app-backup/flexbackup: treeclean Closes: https://bugs.gentoo.org/602382 Signed-off-by: Florian Schmaus <flow@gentoo.org> app-backup/flexbackup/Manifest | 1 - .../files/flexbackup-1.2.1-afio-large-files.patch | 13 - .../flexbackup/files/flexbackup-1.2.1-bash.patch | 18 -- .../flexbackup/files/flexbackup-1.2.1-lzma.patch | 114 -------- .../files/flexbackup-1.2.1-mbuffer-switch.patch | 130 --------- ...ackup-1.2.1-perl-5.12-deprecation-warning.patch | 29 -- ...ackup-1.2.1-perl-5.16-deprecation-warning.patch | 11 - .../flexbackup/files/flexbackup-1.2.1-prune.patch | 136 ---------- .../files/flexbackup-1.2.1-quieten.patch | 13 - .../files/flexbackup-1.2.1-remote-bufftest.patch | 59 ---- .../files/flexbackup-1.2.1-secure-tempfile.patch | 72 ----- .../flexbackup-1.2.1-spaces-in-filenames.patch | 296 --------------------- .../files/flexbackup-1.2.1-tar-1.29.patch | 15 -- app-backup/flexbackup/flexbackup-1.2.1-r13.ebuild | 89 ------- app-backup/flexbackup/metadata.xml | 10 - profiles/package.mask | 6 - 16 files changed, 1012 deletions(-)
