Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 601448 - sys-apps/openrc-0.22.4 dmcrypt trying to stop before localmount during shutdown
Summary: sys-apps/openrc-0.22.4 dmcrypt trying to stop before localmount during shutdown
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-02 13:24 UTC by Mikhail Kurinnoi
Modified: 2018-11-02 18:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Kurinnoi 2016-12-02 13:24:20 UTC
I am switched to rc_parallel="YES" feature and faced with issue during shutdown - dmcrypt trying to stop before localmount. Didn't faced this issue with rc_parallel="NO" by some reason.

Could you please correct /etc/init.d/localmount depends:

depend()
{
	need fsck
	use lvm dmcrypt modules mtab
	after lvm dmcrypt modules
	keyword -docker -jail -lxc -prefix -systemd-nspawn -vserver
}

in this way, I have proper shutdown sequence.

Reproducible: Always
Comment 1 William Hubbs gentoo-dev 2017-03-10 00:12:22 UTC
All,

I think the better choice here would be for the mdcrypt service script to
add "before localmount" to its dependencies. If no one objects, since
I'm a member of base-system as well, I will do this in the morning and
revbump cryptsetup.
Comment 2 SpanKY gentoo-dev 2017-03-10 05:51:14 UTC
(In reply to William Hubbs from comment #1)

that dep doesn't belong in the init script itself.  there are plenty of valid scenarios where cryptsetup can run after localmount (it's how i use it).

this looks like another case where neither position would satisfy everyone.  so put a comment into the conf.d so users can pick whichever one that works for them.

as for the default, if cryptsetup is in the default level, will openrc be upset by it ?  if so, then it shouldn't be the default, and we just leave it uncommented.
Comment 3 Larry the Git Cow gentoo-dev 2018-11-02 18:21:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17664fa2cfb06baec8074fc39c0f71a039db7cd3

commit 17664fa2cfb06baec8074fc39c0f71a039db7cd3
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2018-11-02 18:17:40 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2018-11-02 18:21:02 +0000

    sys-fs/cryptsetup: 2.0.5-r1 bump
    
    Closes: https://bugs.gentoo.org/601448
    Closes: https://bugs.gentoo.org/651998
    Package-Manager: Portage-2.3.49, Repoman-2.3.11
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 sys-fs/cryptsetup/cryptsetup-2.0.5-r1.ebuild | 130 ++++++++++
 sys-fs/cryptsetup/files/2.0.5-dmcrypt.confd  | 115 +++++++++
 sys-fs/cryptsetup/files/2.0.5-dmcrypt.rc     | 340 +++++++++++++++++++++++++++
 3 files changed, 585 insertions(+)