Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600570 - x11-misc/xcape-1.2 version bump
Summary: x11-misc/xcape-1.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-23 11:34 UTC by José Romildo Malaquias
Modified: 2017-10-03 19:09 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xcape 1.2 ebuild (simply renamed) (xcape-1.2.ebuild,816 bytes, text/plain)
2016-11-23 16:54 UTC, aditsu
Details
xcape-1.2.ebuild (EAPI=6) (xcape-1.2.ebuild,814 bytes, text/plain)
2017-01-17 11:37 UTC, aditsu
Details
xcape-1.2.ebuild (updated) (xcape-1.2.ebuild,803 bytes, text/plain)
2017-03-04 13:59 UTC, aditsu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description José Romildo Malaquias 2016-11-23 11:34:29 UTC
xcape-1.2 has been released. Please update portage.
Comment 1 aditsu 2016-11-23 16:54:07 UTC
Created attachment 454130 [details]
xcape 1.2 ebuild (simply renamed)

Hi, I checked it and it has fairly small changes. The same ebuild file renamed to xcape-1.2.ebuild seems to work (I'm attaching it here anyway). I installed and tested it and it's working fine.
Devs, please help update in portage.
Comment 2 aditsu 2017-01-15 20:42:59 UTC
There seems to be no activity.. anything else I need to do?
Comment 3 Jonas Stein gentoo-dev 2017-01-16 22:21:35 UTC
Thank you.

# Copyright 1999-2014 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Id$

>> did you check the ebuild with repoman -d full?
>> It is better not to attach the ebuild next time, if you did only a rename

EAPI="5"

>> I suggest to bump to EAPI=6

Then we should assign the ticket to pinkbyte.
Comment 4 aditsu 2017-01-17 11:32:51 UTC
(In reply to Jonas Stein from comment #3)
> did you check the ebuild with repoman -d full?

Never heard of that before, but after some tinkering and metadata generation,
RepoMan sez: "If everyone were like you, I'd be out of business!"

> I suggest to bump to EAPI=6

I did that, will attach the new ebuild.
Comment 5 aditsu 2017-01-17 11:37:16 UTC
Created attachment 460444 [details]
xcape-1.2.ebuild (EAPI=6)

I tested it and looks fine. Funny enough, my Windows key still worked after killing xcape, apparently KDE/Plasma 5 now includes that functionality. But I tested with another modifier key and it's all good.
Comment 6 Harri Nieminen (Moiman) 2017-02-20 05:53:00 UTC
Comment on attachment 460444 [details]
xcape-1.2.ebuild (EAPI=6)

Remove eutils inherit.
Replace eapply_user with default and move it before sed.

Consider sending pull request at github.
https://github.com/gentoo/gentoo/pulls
Comment 7 aditsu 2017-03-04 13:59:37 UTC
Created attachment 465934 [details]
xcape-1.2.ebuild (updated)

Modified as requested.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-10-03 04:55:42 UTC
Comment on attachment 465934 [details]
xcape-1.2.ebuild (updated)

># Copyright 1999-2017 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
># $Id$
>
>EAPI=6
>
>inherit toolchain-funcs
>
>DESCRIPTION="Utility to make modifier keys send custom key events when pressed on their own"
>HOMEPAGE="https://github.com/alols/xcape"
>SRC_URI="https://github.com/alols/xcape/archive/v${PV}.tar.gz -> ${P}.tar.gz"
>
>LICENSE="GPL-3"
>SLOT="0"
>KEYWORDS="~amd64 ~x86 ~amd64-linux ~x86-linux"
>
>RDEPEND="x11-libs/libX11
>	x11-libs/libXtst"
>DEPEND="${RDEPEND}
>	virtual/pkgconfig"
>
>src_prepare() {
>	default
>
>	# Fix path to man and to pkg-config
>	sed -i \
>		-e "/MANDIR/s:local:share:" \
>		-e "s/pkg-config/$(tc-getPKG_CONFIG)/" \

It's better to substitute this for a plain '${PKG_CONFIG}' var reference, and pass that variable below. Otherwise, pkg-config path with slashes (i.e. absolute path) will break sed.

>		Makefile || die
>}
>
>src_compile() {
>	emake CC="$(tc-getCC)"
>}
>
>src_install() {
>	emake DESTDIR="${D}" PREFIX="${EPREFIX}/usr" install
>}

Anyway, that's the only issue I see, so I'll just commit it.

Next time, please supply a git-format-patch or file a pull request.
Comment 9 aditsu 2017-10-03 11:56:41 UTC
Thanks, I didn't write and don't really understand that part about PKG_CONFIG, AFAICT pinkbyte wrote it when committing version 1.1.

> Next time, please supply a git-format-patch or file a pull request.
Not sure what the patch should be for... do you mean a diff between the old and new ebuilds? Or a patch to add the new ebuild to some repository? Or what?
Also, are you talking about a pull request on github? I actually hate git and find it almost impossible to work with; even if I could manage it, I'm not aware of which repository I need to access and not familiar with the steps involved in filing a pull request.
I'm not completely opposed to this stuff, but it would require a lot of extra effort when I'm already struggling with the ebuild syntax and functions, which seem to be constantly changing.
Comment 10 Larry the Git Cow gentoo-dev 2017-10-03 19:09:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3e0ae8477af38c3f66bdbe470c6f629adab68de

commit b3e0ae8477af38c3f66bdbe470c6f629adab68de
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2017-10-03 05:03:16 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2017-10-03 19:09:24 +0000

    x11-misc/xcape: Bump to 1.2, by proxied maintainer
    
    Closes: https://bugs.gentoo.org/600570

 x11-misc/xcape/Manifest         |  1 +
 x11-misc/xcape/xcape-1.2.ebuild | 38 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 39 insertions(+)