Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600460 - net-misc/youtube-viewer - Add a check for media-video/ffmpeg[openssl]
Summary: net-misc/youtube-viewer - Add a check for media-video/ffmpeg[openssl]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zoltan Puskas
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-22 10:25 UTC by charles17
Modified: 2017-06-30 12:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description charles17 2016-11-22 10:25:56 UTC
youtube-viewer itself works but using it (set to mpv) fails without any warning when media-video/ffmpeg is compiled without openssl support.

Using mpv directly with the youtube URL in this case throws the error message.

As long as the mpv error message is not forwarded to youtube-viewer, the ebuild should perform a check for ssl support in media-video/ffmpeg.

Also, the ebuild should have a runtime dependency for the supported media players.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-11-26 12:19:06 UTC
It would be probably good to forward the bug of not passing errors upstream.
Comment 2 Zoltan Puskas 2017-02-01 06:41:19 UTC
PR in progress: https://github.com/gentoo/gentoo/pull/3757
Comment 3 Kevin Bryan 2017-03-28 19:44:08 UTC
Can you make this RDEPEND allow gnutls too?

|| ( media-video/ffmpeg[openssl] media-video/ffmpeg[gnutls] )
Comment 4 Zoltan Puskas 2017-04-03 21:48:33 UTC
Yes, will do. In fact I'll likely move to virtual/ffmpeg.
Comment 5 Zoltan Puskas 2017-05-25 06:56:40 UTC
Created another PR: https://github.com/gentoo/gentoo/pull/4755

Unfortunately virtual/ffmpeg has no openssl/gnutls flags so I remained on media-video/ffmpeg.

Also this PR bumps youtube-viewer to 3.2.7.
Comment 6 Zoltan Puskas 2017-06-25 22:08:58 UTC
Abandoned previous PR since new version was released since then. Upped a new one at https://github.com/gentoo/gentoo/pull/4989, bumping youtube-viewer to 3.2.8. All fixes present of course. :)
Comment 7 Patrice Clement gentoo-dev 2017-06-30 12:25:39 UTC
commit d255de756438544d0aeb12da260cc41483a4e5af (HEAD -> master, origin/master, origin/HEAD)
Author:     Zoltan Puskas <zoltan@sinustrom.info>
AuthorDate: Wed May 24 23:49:49 2017 -0700
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Fri Jun 30 14:25:07 2017 +0200

net-misc/youtube-viewer: version bump to 3.2.8.

Adjusted dependencies according to release, fixed RDEPEND of video players,
allowed ffmpeg with gnutls

Gentoo-Bug: https://bugs.gentoo.org/600460

Package-Manager: Portage-2.3.6, Repoman-2.3.2
Closes: https://github.com/gentoo/gentoo/pull/4989

net-misc/youtube-viewer/Manifest                   |  1 +
.../youtube-viewer/youtube-viewer-3.2.8.ebuild     | 74 ++++++++++++++++++++++
2 files changed, 75 insertions(+)
create mode 100644 net-misc/youtube-viewer/youtube-viewer-3.2.8.ebuild

Merged, thanks!