Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599654 - x11-themes/mate-themes-3.20.10 installs COPYING files
Summary: x11-themes/mate-themes-3.20.10 installs COPYING files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: immolo
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2016-11-13 14:34 UTC by Ulrich Müller
Modified: 2024-01-20 18:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2016-11-13 14:34:55 UTC
$ qlist -e mate-themes | grep COPYING
/usr/share/themes/TraditionalOk/COPYING
/usr/share/themes/TraditionalGreen/COPYING
/usr/share/themes/Menta/COPYING
/usr/share/themes/BlueMenta/COPYING
/usr/share/themes/BlackMATE/COPYING
/usr/share/themes/GreenLaguna/COPYING

We already have a copy of GPL-3 in licenses/ so these shouldn't be installed.

The ebuild currently says LICENSE="LGPL-2.1" so presumably that should be updated too.
Comment 1 Adam Feldman gentoo-dev 2016-11-14 20:34:06 UTC
According to https://github.com/mate-desktop/mate-themes/blob/master/COPYING, the package itself if LGPL-2.1.

Individual themes have their own COPYING files which are installed by the build system.  Would you like me to manually remove those and add their aggregated licenses to LICENSE?
Comment 2 Adam Feldman gentoo-dev 2016-11-14 20:37:03 UTC
(In reply to NP-Hardass from comment #1)
> According to
> https://github.com/mate-desktop/mate-themes/blob/master/COPYING, the package
> itself if LGPL-2.1.
> 
> Individual themes have their own COPYING files which are installed by the
> build system.  Would you like me to manually remove those and add their
> aggregated licenses to LICENSE?

Just an update,  only some of the themes are GPL-3 (those that distribute a separate COPYING file).  All the others are LGPL-2.1
Comment 3 Ulrich Müller gentoo-dev 2016-11-14 21:16:30 UTC
(In reply to NP-Hardass from comment #2)
> > Individual themes have their own COPYING files which are installed by the
> > build system.  Would you like me to manually remove those and add their
> > aggregated licenses to LICENSE?
> 
> Just an update,  only some of the themes are GPL-3 (those that distribute a
> separate COPYING file).  All the others are LGPL-2.1

Well, the policy reference is:
https://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html#easy-installs

"Note: There is no need to dodoc COPYING! The license belongs to ${PORTDIR}/licenses. Sometimes though, you might want to install COPYING regardless, if it explains how different licenses are applied to different parts of the application, for example."

I still think that the last sentence doesn't apply here, but it is debatable. So, maintainer's decision. :)

However, GPL-3 should be added to LICENSE in any case.
Comment 4 Adam Feldman gentoo-dev 2016-11-14 21:19:02 UTC
(In reply to Ulrich Müller from comment #3)
> (In reply to NP-Hardass from comment #2)
> > > Individual themes have their own COPYING files which are installed by the
> > > build system.  Would you like me to manually remove those and add their
> > > aggregated licenses to LICENSE?
> > 
> > Just an update,  only some of the themes are GPL-3 (those that distribute a
> > separate COPYING file).  All the others are LGPL-2.1
> 
> Well, the policy reference is:
> https://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.
> html#easy-installs
> 
> "Note: There is no need to dodoc COPYING! The license belongs to
> ${PORTDIR}/licenses. Sometimes though, you might want to install COPYING
> regardless, if it explains how different licenses are applied to different
> parts of the application, for example."
> 
> I still think that the last sentence doesn't apply here, but it is
> debatable. So, maintainer's decision. :)
> 
> However, GPL-3 should be added to LICENSE in any case.

OK, will add GPL-3 to LICENSES and will mull over how to handle COPYING.

Thanks.
Comment 5 Pacho Ramos gentoo-dev 2018-09-23 11:51:11 UTC
GPL-3 added to latest version
Comment 6 Ulrich Müller gentoo-dev 2022-07-29 09:11:41 UTC
Ping. mate-themes-3.22.22 still installs COPYING in several of it directories.
Comment 7 Larry the Git Cow gentoo-dev 2024-01-20 18:48:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7abc320b443497e4b02822d52f420e42b8730050

commit 7abc320b443497e4b02822d52f420e42b8730050
Author:     Ian Jordan <immoloism@gmail.com>
AuthorDate: 2024-01-20 01:55:14 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-01-20 18:47:55 +0000

    x11-themes/mate-themes: Remove COPYING files
    
    Clean up copying files which aren't needed as the user has already
    accepted this in package.license.
    
    Rewoked removed command based on ulm's suggestion.
    
    Closes: https://bugs.gentoo.org/599654
    Signed-off-by: Ian Jordan <immoloism@gmail.com>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 .../mate-themes/mate-themes-3.22.24-r1.ebuild      | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)