Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 597520 - dev-db/oracle-instantclient: Add proc precompiler support
Summary: dev-db/oracle-instantclient: Add proc precompiler support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Michael Haubenwallner (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-19 10:36 UTC by Stefan Gast
Modified: 2018-10-23 06:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against dev-db/oracle-instantclient/oracle-instantclient-12.1.0.2.ebuild (oracle-instantclient-12.1.0.2-r1.patch,5.10 KB, patch)
2016-10-19 10:36 UTC, Stefan Gast
Details | Diff
dev-db/oracle-instantclient/files/12.1.0.2-precomp-gentoo.patch (12.1.0.2-precomp-gentoo.patch,1.46 KB, patch)
2016-10-19 10:39 UTC, Stefan Gast
Details | Diff
Patch against metadata.xml (metadata.patch,566 bytes, patch)
2016-10-19 10:44 UTC, Stefan Gast
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gast 2016-10-19 10:36:51 UTC
Created attachment 450734 [details, diff]
Patch against dev-db/oracle-instantclient/oracle-instantclient-12.1.0.2.ebuild

At the download site for the Oracle Instant Client, there is also a precompiler package available, which contains precompilers for Pro*C/C++ and Pro*COBOL:
http://www.oracle.com/technetwork/topics/linuxx86-64soft-092277.html

While I'm not familiar at all with COBOL, I need the Pro*C precompiler at one installation, so I have created an updated ebuild for dev-db/oracle-instantclient-12.1.0.2, which also installs the proc precompiler if USE=precomp is set. It works well enough to satisfy my needs, but it might still need some review. I also hope there is no other package claiming /usr/bin/proc.

Attached you'll find a patch against dev-db/oracle-instantclient-12.1.0.2 introducing the precomp USE flag and adding support for the proc compiler.

The patched ebuild also applies a patch against demo_proc_ic.mk, similar to the already existing one against demo.mk. I've called this files/12.1.0.2-precomp-gentoo.patch and I'll post it in another attachment.
Comment 1 Stefan Gast 2016-10-19 10:39:20 UTC
Created attachment 450736 [details, diff]
dev-db/oracle-instantclient/files/12.1.0.2-precomp-gentoo.patch

Patch against sdk/demo/demo_proc_ic.mk
Comment 2 Stefan Gast 2016-10-19 10:44:39 UTC
Created attachment 450738 [details, diff]
Patch against metadata.xml

Patch adding a description of the precomp USE flag to metadata.xml
Comment 3 Larry the Git Cow gentoo-dev 2018-10-19 16:28:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a8db975b241e26c2cfcc52728829b74bfc2e166

commit 5a8db975b241e26c2cfcc52728829b74bfc2e166
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: 2018-10-19 15:43:13 +0000
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: 2018-10-19 16:25:24 +0000

    dev-db/oracle-instantclient: revbump
    
    Closes: https://bugs.gentoo.org/578402
    Closes: https://bugs.gentoo.org/597520
    Closes: https://bugs.gentoo.org/652096
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    Signed-off-by: Michael Haubenwallner <haubi@gentoo.org>

 dev-db/oracle-instantclient/Manifest               |  14 +
 .../files/18.3.0.0-makefile.patch                  |  40 +++
 dev-db/oracle-instantclient/metadata.xml           |  11 +-
 .../oracle-instantclient-18.3.0.0.ebuild           | 342 +++++++++++++++++++++
 4 files changed, 402 insertions(+), 5 deletions(-)
Comment 4 Michael Haubenwallner (RETIRED) gentoo-dev 2018-10-19 16:38:19 UTC
Ohw, haven't recognized your additional patches before...
Comment 5 Michael Haubenwallner (RETIRED) gentoo-dev 2018-10-22 12:33:12 UTC
Stefan, please test, thanks!

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e1a42dfb7912831eb273d0356822b3870f5fdb7a

commit e1a42dfb7912831eb273d0356822b3870f5fdb7a
Author:     Michael Haubenwallner <haubi@gentoo.org>
AuthorDate: Mon Oct 22 14:21:17 2018 +0200
Commit:     Michael Haubenwallner <haubi@gentoo.org>
CommitDate: Mon Oct 22 14:22:02 2018 +0200

    dev-db/oracle-instantclient: fix precomp install
    
    With credits to Stefan Gast in bug#597520, tweak paths in
    demo_proc_ic.mk and pcscfg.cfg, move the latter to /etc/oracle/,
    and do not install the Pro*COBOL precompiler, but Pro*C only.
    Also, use relative paths for symlinks.
    Closes https://bugs.gentoo.org/597520
    
    Package-Manager: Portage-2.3.49, Repoman-2.3.10
    Signed-off-by: Michael Haubenwallner <haubi@gentoo.org>

 .../files/18.3.0.0-makefile.patch                  |   2 +-
 .../files/18.3.0.0-proc-makefile.patch             |  27 ++
 .../oracle-instantclient-18.3.0.0-r1.ebuild        | 375 +++++++++++++++++++++
 3 files changed, 403 insertions(+), 1 deletion(-)
Comment 6 Stefan Gast 2018-10-23 06:57:04 UTC
Michael, thanks, it works fine now! :)