vte:2.91 slot is the only one maintained by vte upstream, hence, we should try to use it if possible. It seems that upstream added support for it some time ago... but probably they didn't release a newer version recently including it. The patch is provided at: https://sourceforge.net/p/lxde/patches/493/ Thanks
Hi, lxterminal does not work for me with gtk-3. I checked what arch linux people do, they also backport the patch you mention, and even a bit more. I created a pull request with their patch. See https://github.com/gentoo/gentoo/pull/2472 It seems to work for me.
Created attachment 449292 [details] lxterminal-0.2.0-r2.ebuild
Created attachment 449294 [details, diff] lxterminal-0.2.0-new-vte.diff
Attached an ebuild, I'll commit it if nobody complains within a few days. I saw the pull request only after that, it's almost identical, except that in the pull request the patch is not properly named.
With 13kb I wonder if the patch is already big enough that we don't want it in the tree. Opinions? (Obviously all would be easier with a new upstream version...)
I think the limit repoman forces is no > 20 Kb, then, it could be carried in the tree without problems
I just pinged upstream if they can make a new release, there are a lot of bugfixes in the repo that sound relevant. I'll wait a few days, I'd much prefer just having a new release tarball with all the fixes.
the patch doesn't work for me. As we just patched configure.ac, but not configure script, we need to run autoconf first to make sure the version check of vte updated to configure script. best regards younky
Ok, first I patched it and then run autoconf manually, then ebuild lxterminal-0.2.0-r2.ebuild merge, it successfully merged the package and runs without issues. Thanks
I'm the upstream maintainer for lxterminal (and a Gentoo user too). I'll see about pushing a release this week. LXDE doesn't officially support gtk3 so lxterminal might not be the only thing with strange issues. I must say that I've found forced disabling of gtk2 in various ebuilds a tad annoying too (particularly gvfs). At least Gentoo lets us have overlays. Still support for gtk3 is planned for 'classic' lxde down the road. It's slow going because most of the dev focus is on LXQT, leaving only a couple grumpy old dudes (like me) on the GTK side of things and we're both mainly using GTK2.
We could apply some patch in the meanwhile. In the current state in portage, lxterminal compiled with gtk3 use flag crashes on opening. My pull request (and probably Hanno's patch) fix this.
any news?
Any updates? :/ If no new snapshot is taken, I would apply the patch then
There's a new upstream version, I just hadn't found the time to look at it. Will try to push an update within the next couple of days.
New upstream version is discussed in #607838 They have an ebuild for it. I would be glad if it finally made its way into gentoo repo.
Version 0.3.0 See https://github.com/gentoo/gentoo/pull/5362
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bfe2786432826bec81d7685001c3eca663ed1c26 commit bfe2786432826bec81d7685001c3eca663ed1c26 Author: charIes17 <charles17@arcor.de> AuthorDate: 2017-12-13 19:51:53 +0000 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: 2018-03-05 21:56:38 +0000 lxde-base/lxterminal: version bump to 0.3.1 (CVE-2016-10369). Bug: https://bugs.gentoo.org/635992 Closes: https://bugs.gentoo.org/607838 Closes: https://bugs.gentoo.org/595904 - Adjusted HOMEPAGE (avoid redirect). - Adjusted tarball from.gz to .xz. - Make repoman happy by re-adding ~arm64. - Add LINGUAS handling. - Add handling of live ebuild. Package-Manager: Portage-2.3.13, Repoman-2.3.3 Closes: https://github.com/gentoo/gentoo/pull/5362 lxde-base/lxterminal/Manifest | 1 + lxde-base/lxterminal/lxterminal-0.3.1.ebuild | 47 ++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+)
